search

Team-RTG / Realistic-Terrain-Generation

The Realistic Terrain Generation mod for Minecraft.
GNU General Public License v3.0
245 stars 118 forks source link

Memory Leak RTG #1351

Closed enterprise12nx closed 4 years ago

enterprise12nx commented 4 years ago
Affected Mod Versions: The modpack is Industrial Age The Turning by enterprise12 on twitch for the modlist

(Please list other mods and their versions if you feel they are relevant to this issue. i.e. Biomes O' Plenty)

Issue Description:

(Please provide screenshots if neccessary/possible. Images can be dragged & dropped into this window.)

In a large modpack i created me and many users reported a memory leak, ram usage continues to climb slowly no matter how much or little is provided until minecraft freezes often

Removing rtg even in a default world type solved this issue, im aware it is an alpha snapshot version. Looking through the latest.log i have not seen anything related to RTG in the logs, is there anything i can provide to assist with this issue?

Steps to reproduce the issue: (If it's easily reproducible.)
  1. Use RTG?
Extra Information:
srs-bsns commented 4 years ago

There is no memory leak in RTG, there is only poor memory management in 1.12 without proper JVM settings, and those are highly dynamic based on loaded mods and available server resources. It is widely known that large mods packs require a server to be restarted on a regular basis to be able to free up memory that a running JVM is unable to.

enterprise12nx commented 4 years ago

this happens even in singleplayer, i have a massive player base doing testing as this was a fairly large modpack in 1.7 i maintained for several years and am bringing back for 1.12.2

While you can only believe me by word, whenever i get crashes or errors, i usually solve them myself by looking through the latest.log I went through removing tons of mods to try to isolate this problem, removing rtg was the only mod that fixed our "memory leak" problem, using F3 to watch the ram usage, with this mod ram continues to climb in usage, even while standing still, whether its and rtg or non rtg world, in single player or multiplayer. the memory leak only happens client side, not server side. Removing this mod fixes the issue on the client.

We are using Surge, Vanillafix, Sledgehammer, foamfix, betterfps all together, to improve performance, which helps ram usage as well

Robijnvogel commented 4 years ago

Since RTG is completely server-sided and does not even need to be installed on the client when playing on a standalone server, I doubt that it would ever have a direct impact on client-sided RAM usage, expecially when the world type is not even being used.

However I could see how rendering the higher trees that were generated by RTG's server-sided processes could take a little extra RAM.

Have you tried running VanillaFix' profiler to see what takes up all of this RAM exactly?

enterprise12nx commented 4 years ago

Since RTG is completely server-sided and does not even need to be installed on the client when playing on a standalone server, I doubt that it would ever have a direct impact on client-sided RAM usage, expecially when the world type is not even being used.

However I could see how rendering the higher trees that were generated by RTG's server-sided processes could take a little extra RAM.

Have you tried running VanillaFix' profiler to see what takes up all of this RAM exactly?

no how do you run the vanillafix profiler?

srs-bsns commented 4 years ago

This issue tracker is for actual issues with RTG, not for tech support, or tracking issues that are unsubstantiated. Please take this discussion elsewhere, such as Discord.

Robijnvogel commented 4 years ago

no how do you run the vanillafix profiler?

Shift + F3 as it says on the CurseForge page .

For further questions I would indeed like to refer you to the Discord server/channel at least until you find out more about RTG's (non-)involvement in these performance issues. ;)