Team-Resourceful / ResourcefulBees

Minecraft Mod for creating highly customized bees
https://www.resourcefulbees.com
GNU Lesser General Public License v3.0
75 stars 31 forks source link

[Bug]: Processing doesn't start for combs that require bottles if you add the bottles after the combs #348

Open mouseas opened 2 years ago

mouseas commented 2 years ago

Bug Description

When using a powered single-block centrifuge, if you have combs that require a bottle to process, and the empty bottle slot is empty when you insert the combs, then later insert empty bottles, the centrifuge will not start processing. If the bottles are inserted first, followed by the combs, processing starts as expected.

I haven't tested it with either of the multiblock centrifuges, but those should definitely be tested as well.

How to Reproduce?

  1. Place and power a single block powered centrifuge.
  2. Insert a comb which requires empty bottles in order to process it.
  3. Insert empty bottles. Processing will not start.
  4. Remove the comb and place it back in the input slot. Processing will start.

Expected Behavior

Processing should start if all the requirements are met, regardless of the order items are inserted.

Version

ResourcefulBees-1.16.5-0.10.6.jar

Mod Loader Version

Forge 36.2.35, MC 1.16.5

Logs or additional context

Modpack is Sky Bees 2 via Curseforge

Acknowledgement

Epic428 commented 2 years ago

Iirc the reason for this is because there’s two versions of the recipe. One with bottles and one without because without bottles we put honey into an internal tank. So when you put combs in without a bottle we try to get the recipe for it and then we cache that recipe. Adding bottles after the fact isn’t going to change which recipe is being done without resetting the cached recipe. Recipe lookups can get expensive if you make too many calls, so we try to cache the data where we can to reduce map lookups.

however in 1.19 this would be a non issue due to the fact that bottle stuff no longer exists.

cmd276 commented 2 years ago

I was going to do a report for this if it wasn't done already. But since it's mostly here, I feel confident enough I can add onto this one instead. If you wanted me to make a new report instead, let me know and I will.

My differences from original post:

Bug Description Same as original post, But I wanted to specifically point out the Spelling Honeycomb has been doing this to me, and it only has one recipe. (None of the other Honeycombs do this to me yet, just the Spelling Honeycomb.)

Version ResourcefulBees-1.16.5-0.10.7.jar

Mod Loader Version Forge 36.2.34, MC 1.16.5

Logs or additional context Modpack is Enigmatica 6 Expert