Review: BeforeLanding.jsx and VolunteerEvents.jsx

[kristineorpilla03]

Overview

The focus for this code review will be centered around the files in this project. Please pay attention too:

• Javascript issues
• React components

Review Branch

review-8

Files to review

• BeforeLanding.jsx
• VolunteerEvents.jsx

Checklists

• Architecture
• Design
• JS
• React
• Testing

Due date

03/25

For more information

The review process is documented at: http://courses.ics.hawaii.edu/ics414s21/morea/review/reading-idpm-review.html

[choytr]

BeforeLanding.jsx JS-06: get rid of console logs lines 17-21 VolunteerEvents.jsx JS-06: get rid of console logs lines 16-21

[kristineorpilla03]

BeforeLanding.jsx

JS-06: L17-21 Remove the console.logs in the subscription. L32: Maybe change this to use the LoadingSpinner component instead L40, 98: Possibly add style code into the CSS file

VolunteerEvents.jsx

JS-06: L16-21 Remove the console.logs in the subscription. Be consistent with spacing in the code → adding/no spaces between different parts of the code

[UHMyafeiwang]

BeforeLanding.jsx

Design-05 : Console logs in useTracker should be removed in production code JS-07: Console logs present for subscription status, not recommended for

VolunteerEvents.jsx

JS-07 : Console logs should be removed

[colas002]

BeforeLanding.jsx

JS-06: L17-21 unnessary console.logs, can be removed DE-04: L110-113 large amount of commented out code

VolunteerEvents.jsx

JS-06: L16-21 unnecessary console.logs, can be removed

[josiahkila]

BeforeLanding.jsx

JS-06: L17-21 Remove the console.logs in the subscription. L40, 98: styling

VolunteerEvents.jsx

ES-LINT: L16-21

[juvyannl]

BeforeLanding.jsx

JS-06: L17-21 Remove console.logs

VolunteerEvents.jsx

JS-06: L16-21 Remove console.logs

[destinyshishido]

BeforeLanding.jsx

L17-21 Unnecessary console logs

VolunteerEvents.jsx

L16-21 Unnecessary console logs