search

Team-Roots / voluntree-meteor-react

MIT License
0 stars 0 forks source link

Review: RegistrationFormCard.jsx and LandingPanels.jsx #151

Open kristineorpilla03 opened 5 months ago

kristineorpilla03 commented 5 months ago

Overview

The focus for this code review will be centered around the files in this project. Please pay attention too:

Review Branch

review-9

Files to review

Checklists

Due date

04/01

For more information

The review process is documented at: http://courses.ics.hawaii.edu/ics414s21/morea/review/reading-idpm-review.html

destinyshishido commented 5 months ago

RegistrationFormCard.jsx

L104 - Type error?

LandingPanels.jsx

Lots of commented out code Remove console logs L14, L15, L141, L142

kristineorpilla03 commented 5 months ago

RegistrationFormCard.jsx

Replace L8-14 (exampleInfo) with subscribing to the collection

LandingPanels.jsx

No errors can be found

UHMyafeiwang commented 5 months ago

RegistrationFormCard.jsx

Design-03 : No dead code is present

LandingPanels.jsx

No errors found

tliam1 commented 5 months ago

RegistrationFormCard.jsx

There are github action failures, probably due to eslint errors

LandingPanels.jsx

remove old/useless comments remove old console logs remove useless imports

colas002 commented 5 months ago

RegistrationFormCard.jsx

L8-14 should be subscribing to the collection L100-102 submit button are not used

LandingPanels.jsx

remove commented out code

josiahkila commented 5 months ago

RegistrationFormCard.jsx

L100-102useless button

LandingPanels.jsx

Remove useless code

juvyannl commented 5 months ago

RegistrationFormCard.jsx

L100-102 Submit button not needed

LandingPanels.jsx

No errors found