search

Team-Silver-Sphere / SquadJS

Squad Server Script Framework
Boost Software License 1.0
167 stars 128 forks source link

Added host property to ftp config to limit confusion as this is a common configurable property. #346

Closed mbartisan closed 8 months ago

CodeRedDev commented 9 months ago

This might require a ftp:host description in the README.md to be complete.

Even though I'm questioning the sense in this parameter overall. If I'm not mistaken then the log should always be on the server that hosts the game server. So there should not be a parameter to set another ftp:host and this line

https://github.com/Team-Silver-Sphere/SquadJS/blob/923c601292cf9264fd8b30cfa7baec9acefb45d8/squad-server/index.js#L184

should always take this.options.host.

mbartisan commented 9 months ago

Specifying the ftp host is required to work with some server providers. See Issue #299 where this feature was implemented. This PR is adding documentation to the ability.

CodeRedDev commented 9 months ago

Ah alright sorry.

My first point should be valid though that the ftp:host should be descibed here

https://github.com/Team-Silver-Sphere/SquadJS/blob/afcab47e8122b796cc45b1a7788e9a2013b837f0/README.md?plain=1#L94

Maybe also by mentioning #299 👍