Closed denizetkar closed 1 month ago
I have submitted a PR that addresses duplicate Victim field that you reported: #364
Hi @Ulibos,
Any updates on testing the PR?
We are using a plugin that queries data from layers infrequently so I can't vouch for a full comprehensive test but so far I haven't seen a single failure on this part of the code.
Should we merge it then?
I'm all for merge but I'm not the one calling the shots.
There is another merge about to happen soon that will require rewrites again. Merges are on hold until then.
Force pushing. Mobile UI is preventing conversation resolution.
Description
SquadServer
regularly invokesupdateLayerInformation
to update the current and next layer variables, namelythis.currentLayer
andthis.nextLayer
.Layers
class,getLayerByName
method, which filters the pulled layersthis.layers
by thename
field.https://raw.githubusercontent.com/Squad-Wiki/squad-wiki-pipeline-map-data/master/completed_output/_Current%20Version/finished.json
SquadRcon
class,getCurrentMap
method which uses the RCON commandShowCurrentMap
. This command returns an answer likeCurrent level is Jensen's Range, layer is JensensRange_USA-RGF, factions USA RGF
. The problem here is 2-fold:^Current level is (.*), layer is (.*)
Because the 2nd regex group actually matches a string likeJensensRange_USA-RGF, factions USA RGF
layerid
field in the pulled layersWhat this PR does
Solves those 2 problems by:
ShowCurrentMap
andShowNextMap
as:^Current level is ([^,]*), layer is ([^,]*)
layerid
field instead ofname