Team-VoW / VoicesOfWynn-Website

Public website for the Minecraft mod "Voices of Wynn"
4 stars 4 forks source link

Fix the sidebar issue on mobile devices #24

Closed ShadyMedic closed 2 years ago

ShadyMedic commented 2 years ago

Apparently, the main bar won't fill the whole page when on a mobile device. image

Just5MoreMinutes commented 2 years ago

Thats weird... On my preview in firefox and on my device, it is centered and works normally... Could you maybe tell me which screen sizes are the ones that cause issues (only if you know of course!)?

ShadyMedic commented 2 years ago

I just asked the person who reported this. Gonna let you know once I get an answer.

Just5MoreMinutes commented 2 years ago

Alright perfect! Thanks a lot

ShadyMedic commented 2 years ago

I'm seeing 2400×1080 (it's a Samsung Galaxy Note20)

Just5MoreMinutes commented 2 years ago

I have used these exact sizes for the preview of the mobile website and my output looks like this: idrk I have applied the center tag to the entire main tag now which basically is the white main bar; I'm not too sure whether or not this fixes the problem so I will leave this issue open for now :)

Just5MoreMinutes commented 2 years ago

I had to remove the center tag again since it led to huge complications with any card on the entire website... I hope I can figure something out

ShadyMedic commented 2 years ago

I'll ask the person who reported it to check it again.

Maybe they just had the old styling cached.

ShadyMedic commented 2 years ago

Unfortunately, the problem still persists. And it's present on my phone as well. Try loading the website on your phone instead of using devtools to simulate it, I guess there're some differences in dev tools compared to real phone devices.

Just5MoreMinutes commented 2 years ago

I suppose it is a problem from devtools... I checked it on my phone and the issue persists I will change the width of the main element to fit the average mobile size :)

Just5MoreMinutes commented 2 years ago

I think I found a temporary fix. I cant really test it since there is no possible way for me to actually test it in action, but this time I used several different ways of testing and it all seemed to fit

-> remains open for now

ShadyMedic commented 2 years ago

I'm a fircking idiot.

Do you know why it didn't work on my phone? Because I was trying to display the freecluster.eu website without realising, that I pulled the changes only to my local server, not the testing online one.

It's too late for me to deploy to the testing server now, but I'll let you know as soon as possible if this fixes the solution.

I'm so sorry for this.

Just5MoreMinutes commented 2 years ago

It's alright :)

Just tell me whenever you know whether it works or not!

ShadyMedic commented 2 years ago

Unfortunately, while the problem with quests was solved, this one seems to persis. Even in DevTools for me. image

ShadyMedic commented 2 years ago

Also the background image disappeared. Not sure if this isn't an expected behaviour though.

Just5MoreMinutes commented 2 years ago

I think I might have found a solution for the problem? I hope this actually works :)

Also, I added more screen sizes! So the logo and the vertical line are looking better at different screen sizes!

ShadyMedic commented 2 years ago

image I'm afraid that I observe no positive change in this (screenshot from my phone).

Just5MoreMinutes commented 2 years ago

Well that sucks to say the least. I can try to increase the width of the main element in another way then I do right now, I suppose. I doubt that will work though.

The 2 hardest things remain unfixed and I have a huge exam coming up, panic

But it's alright, I think I can get it done over the weekend, I hope :')

ShadyMedic commented 2 years ago

Well, this isn't as urgent as it seems plus this isn't stopping me from working on other features while you're busy, so don't sweat it. When you have time for development, better invest it into #35 #36 and #38 :)

ShadyMedic commented 2 years ago

This can't be verified very well unless the current code is deployed to a public server. Just so you know I didn't forget about this.

ShadyMedic commented 2 years ago

It's not perfect, but I'd say that it mostly works. It's not like many people will browse this website on their phones anyway.