Closed kmaxii closed 2 years ago
just to elaborate on some points @kmaxiyt mentioned above.
this mainly affects points 3, 4 and 5. I'll just go through them chronologically so it makes more sense.
Point 3: could you maybe attach a screenshot of the problem? I tested it on my device and it doesn't seem to occur there... additionally, what browser are you using?
Point 4: this will be hard to implement since not just the size of the cards will have be changed drastically, making them hardly readable, but also the JS behind the resizing of the contributors names. we can move the cards more towards the center and shorten the distance inbetween them, but anything else would just make it unnecessarily hard to navigate
Point 5: same problem as in # 4 if I understood correctly what you mean by that
please tell me whether you'd still like to see those changes, or rather, the slightly altered version of the suggestions. also, please attach a screenshot of # 3 because, as said, the problem doesn't occur on my end apparently
Update 1: The suggestion for having 2-3 people displayed in one line on mobile has been implemented.
Now 2 cards will be shown in one line for any device under the width of 1000px
.
Tasks: A list of suggestions provided in this issue
[x] The play button of recordings is barely, if at all, reachable
[ ] A lot of the text in account information is not on screen
[ ] When you search for a quest in Mod contents, the result is too far down.
[x] On the credits page one person shows up (horizontally) at a time. This makes going through all credits really painful. 2-3 should show up next to each other.
[x] When you search for a quest all NPCs show up vertically, some should show up next to each other so that you don't have to scroll as much.
Update 2: All pages that have recordings on them have been reworked to place the recordings in the center. The voting buttons are slightly below. This should work for every voice actor and quest. Also, it doesn't interfere with the normal styling.
Update 3:
When you search for a quest in Mod contents, the result is too far down.
@kmaxiyt, could you please send a screenshot of this issue? I don't seem to be able to recreate it...
When you search for a quest all NPCs show up vertically, some should show up next to each other so that you don't have to scroll as much.
On devices over the width of 600px
or 37.5rem
there will be 3 quest cards in one row.
@kmaxiyt can you please provide the screenshot that Minutes asked for?
@T-D3V Did you verify this issue on an actual phone to ensure it's fixed? Please let me know if you need to deploy the code to production first.
Nah this was resolved somewhere near public launch just never got arround to closing the issue.
But yeah I've used my phone for it.
@kmaxiyt since it's you who reported the issue, can you please verify that it's fixed for you as well?
The bugs are fixed! No text outside of the screen :D
On the credits page one person still shows up (horizontally)one at a time. So this was not changed, but I guess it's alright if it would be way to much work ;)
All these issues are on phone.
The play button of recordings is barely, if at all, reachable.
A lot of the text in account information is not on screen
When you search for a quest in Mod contents, the result is too far down.
On the credits page one person shows up (horizontally) at a time. This makes going through all credits really painful. 2-3 should show up next to each other.
When you search for a quest all NPCs show up vertically, some should show up next to each other so that you don't have to scroll as much.