Team-VoW / WynncraftVoiceProject

A Wynncraft mod project for introducing voices in quests
GNU Affero General Public License v3.0
18 stars 8 forks source link

Add a speed setting #19

Open dragoncop opened 6 months ago

dragoncop commented 6 months ago

I read to add suggestions to the issues on your github which is why I am here.

I am a pretty fast reader but it takes a decent amount of effort to read which is why I got this, the problem I have is that since I read decently fast and have adhd it takes a while to go through the voice lines if I am trying to actually listen to them so I end up listening to it half way and then skipping because I finished reading it. I was thinking of if you could add some type of speed multiplier or something like youtube has. I do not expect you to have them all go back and re-read all of the lines just faster because that would be outrageous. Anyways, great mod its nice to use.

ShadyMedic commented 6 months ago

This is actually a neat idea that can help solve some problems with dialogues appearing faster than the sound finishes to play, which leads to cut-offs.

I'm not proficient with Java functions, but there should be an option to set a playback speed, right @kmaxii ?

kmaxii commented 6 months ago

With Minecrafts audio system it is not possible.

What could be done and what I maybe should be doing anyways is implement my own audio playback system that I made for the cloud version into the normal one. I am also working on a reverb system for that which is almost done, so might be good to implement it here so that everyone gets the same effects.

Great suggestion, impossible for now but will definitely keep this open and should be possible to implement once we moved to the custom audio engine.

kmaxii commented 1 month ago

With #37 the different audio engine has been implemented. Will soon start to work on this