search

Team-fastML / fastML

A Python package built on sklearn for running a series of classification Algorithms in a faster and easier way.
https://pypi.org/project/fastML/
MIT License
50 stars 23 forks source link

module imports #4

Closed Silas-Asamoah closed 4 years ago

Silas-Asamoah commented 4 years ago

Is your feature request related to a problem? Please describe. The module imports within the fastML function will cause calls to the function to take longer which reduces efficiency and it's not necessary since it's only one source file.

Describe the solution you'd like Putting the imports at the top of the function because it is a small cost that is paid once and easy for dependency tracking.

Describe alternatives you've considered N/A

Additional context N/A

buabaj commented 4 years ago

good thinking

buabaj commented 4 years ago

did you test your changes?

Silas-Asamoah commented 4 years ago

5