search

Team-uMigrate / umigrate

Source code for the uMigrate project
13 stars 2 forks source link

Feature/Added room membership join date #432

Closed JerryBii closed 3 years ago

JerryBii commented 3 years ago

Created membership endpoints to add new users to rooms, thereby allowing for retrieval of room join date.

deandrebaker commented 3 years ago

Sorry, this is kinda nitpicky but can you please squash your commits together and add your ticket number in the resulting commit? Just makes it easier for tracking.

Looks good otherwise, nice work! I will approve the request once ^ is done

@NihalPotdar all commits will be squashed when merging to main by default 👍 . But yeah adding the ticket number to the title of the PR will add the ticket number to the merge commit, which is a good idea 👍

JerryBii commented 3 years ago

@JerryBii looking better! Just missed some more mistakes

Made the requested changes

deandrebaker commented 3 years ago

@JerryBii please don't merge this branch in until PR #449 has been merged in to main. Thanks