Introduce `Alliance` and use it in all match-related classes - Githubissues

Team1690 / Scouting-Frontend

10 stars 1 forks source link

Introduce `Alliance` and use it in all match-related classes #323

Open giladwo opened 1 year ago

giladwo commented 1 year ago

We've got: https://github.com/Team1690/Scouting-Frontend/blob/81d92e214bf88a930eaaf2b0de584599e75bce21/scripts/fetch_matches_tba.dart#L204-L210 https://github.com/Team1690/Scouting-Frontend/blob/931b1c291e71fe44cc6b48884d8bd4cadc8437ad/lib/views/pc/status/status_screen.dart#L333-L344

And we forgot to change where it actually matters: https://github.com/Team1690/Scouting-Frontend/blob/931b1c291e71fe44cc6b48884d8bd4cadc8437ad/lib/models/matches_model.dart#L3-L30

We want:

[ ] Introduce an Alliance to handle color and driver station position responsibilities of its teams (getAllianceStation should be a method, for instance)
[ ] Change all match-related classes to use the common alliance abstraction.

This also relates to

https://github.com/Team1690/Scouting-Frontend/pull/315/files#r1060447326

_Originally posted by @giladwo in https://github.com/Team1690/Scouting-Frontend/pull/315#discussion_r1063652397_

giladwo commented 1 year ago

Also relates to https://github.com/Team1690/Scouting-Frontend/pull/315#discussion_r1063627751

ItayNaumann commented 1 year ago

didnt fully understood the task, will need a bit of explanation hopefully in a voice call