Team2168 / 2014_Main_Robot

Code for the 2014 FRC season.
Other
2 stars 1 forks source link

Provide overloaded constructors for RotateDrivetrainRelative Command #74

Open jcorcoran opened 10 years ago

jcorcoran commented 10 years ago

https://github.com/Team2168/FRC2014_Main_Robot/blob/master/src/org/team2168/commands/drivetrain/RotateDrivetrainRelative.java

Add overloaded constructors which limit the number of parameters that need to be provided.

RotateDrivetrainRelative(double angle) { this(angle, false); }

//maybe this one is unintuitive to add RotateDrivetrainRelative() { this(0.0, true); }

NotInControl commented 10 years ago

agreed, on my list of things to do. I didn't do it...yet because, I was trying to think if there was a way to remind the user that the value passed will only be the value as seen when commandBase init is called.

And I wanted a more obvious way the user could recognize that rather than simply putting it in the comments.

Like maybe using the constants object in the constructor, instead of double. But then again, you can change constants on the fly using the .set method.

On my low level list of things to correct.