Team2168 / 2014_Main_Robot

Code for the 2014 FRC season.
Other
2 stars 1 forks source link

Fix F310 class Trigger Buttons #86

Closed jcorcoran closed 10 years ago

jcorcoran commented 10 years ago

It looks like the sign of the values on the axis used for triggers are backwards (when compared to 2012).

2012 code has:

auxTriggerR = new JoystickAnalogButton(auxstick, 3, -0.5),
auxTriggerL = new JoystickAnalogButton(auxstick, 3, 0.5),

right is negative values, left is positive. Looks like F310 class has the opposite defined. This would be consistent with robot code (intake motors drive ball in with a negative value out to the motor controller, but a positive number should be required). Intake wiring was mapped using the joystick triggers, so when holding the right button down , the left command is actually running...

Once this is fixed, need to go through all the code and make sure the intake fwd/rev drive commands actually run in the correct direction.

NotInControl commented 10 years ago

Is this still an issue? I thought the problem with this was that the motors were plugged in reverse. If not we should correct the class.

Do you think it is wise to have the getAxisRaw() methods take in a boolean which inverts them, so as to avoid the whole down is positive/up is negative on the sticks?