search

Team2168 / 2016_Main_Robot

Code for the 2016 season
0 stars 0 forks source link

Final falcon claw #52

Open burningombre opened 8 years ago

burningombre commented 8 years ago

Completed code for Falcon Claw. Please review before merging, only my two latest commits should be merged

jcorcoran commented 8 years ago

The falconclaw and interpolation functions do belong in OI. If you left it as is, calling Drivetrain.getLeftSpeed would return to you a joystick value, that doesn't make sense to me. I'd expect a method in the DT subsystem with that name to return a rate of travel (distance/second). OI is the unit in which we interface with the controllers, that's the right place for this kind of stuff in my mind.

What was your reason for moving it into Drivetrain in https://github.com/Team2168/2016_Main_Robot/commit/b74cbeee72fd40bfeabd5dd95949be0e85b7d465 ?

Also you should modify the DriveWithJoystick command to make use of the interpolated joystick values, otherwise the code you're adding won't ever get run.

burningombre commented 8 years ago

Updated the code, should all be good now Also, driving*\ (I can't English tonight)