search

Team2168 / 2022_Main_Robot

Other
3 stars 0 forks source link

Shooter Subsystem + Commands (Waiting for testing) #14

Closed namanp07 closed 2 years ago

namanp07 commented 2 years ago

James created the subsystem code (although I did add some methods to the subsystem), and I did the command code for various different commands. I want someone to review the code because I know there are bugs and issues here so I just want someone to look this stuff over for things I didn't catch/things I don't know how to troubleshoot.

(UPDATE 1/31/22: The shooter subsystem is basically complete now, read the latest commits for more info, TD;LR, the code for the subsystem and commands is now done, fully up to date, and error free expect for the SetTargetLocationSpeed command although I was told not to work on that, so its basically done)

(UPDATE 2/2/22: I updated with James' requests, I am not sure what other commands/fixes to add to this, as well as how to ingerate the controller inputs to work with the commands as well. If someone could suggest or explain what I do, that would be great)

jcorcoran commented 2 years ago

You should move the commands related to the shooter subsystem below a new shooter directory under the commands directory. like the other subsystems commands\shoooter

You'll also need to revise the package name of your command classes to something like package org.team2168.commands.shooter;