search

Team3176 / Code_2024

Robot Code for 2024 FRC game Crescendo
BSD 3-Clause "New" or "Revised" License
2 stars 0 forks source link

cleaning up phoenix 6 calls #64

Closed jheidegger closed 7 months ago

jheidegger commented 7 months ago

Updating IO classes to use the BaseStatusSignal method which saves IO time and prevents loop overruns. Also uses the optimizeCanBus options

char3176 commented 7 months ago

I would like 2 larger changes before I delve further.

  1. all systems should use either "current" or "amps" not either/or. Pick one.
  2. I would like amp inputs to specify source, if amps is gotten from the Stator, make it "xxxStatorAmps" or "xxxStatorCurrent". Does that make sense?

It is close. Code looks ok. Just want to take the opportunity to clean up our conventions and standardize.

char3176 commented 7 months ago

I'm good with current code to be merged. Well done, Jon.