search

Team4079 / Rapid-React-2022

Other
0 stars 0 forks source link

No Magic Numbers #3

Closed nguyen-b closed 2 years ago

nguyen-b commented 2 years ago

You should pull this out to a new constant or variable or use Constants file instead of magic numbering this.

https://github.com/OASTEM/Rapid-React-2022/blob/32054d1818b4a4878e84290b4bf15184e42254bc/src/main/java/frc/robot/LogitechGamingPad.java#L78

nguyen-b commented 2 years ago

More Magic Numbers:

https://github.com/OASTEM/Rapid-React-2022/blob/32054d1818b4a4878e84290b4bf15184e42254bc/src/main/java/frc/robot/LogitechGamingPad.java#L120

https://github.com/OASTEM/Rapid-React-2022/blob/32054d1818b4a4878e84290b4bf15184e42254bc/src/main/java/frc/robot/LogitechGamingPad.java#L191

https://github.com/OASTEM/Rapid-React-2022/blob/32054d1818b4a4878e84290b4bf15184e42254bc/src/main/java/frc/robot/LogitechGamingPad.java#L201

https://github.com/OASTEM/Rapid-React-2022/blob/32054d1818b4a4878e84290b4bf15184e42254bc/src/main/java/frc/robot/LogitechGamingPad.java#L211

https://github.com/OASTEM/Rapid-React-2022/blob/32054d1818b4a4878e84290b4bf15184e42254bc/src/main/java/frc/robot/LogitechGamingPad.java#L221

https://github.com/OASTEM/Rapid-React-2022/blob/32054d1818b4a4878e84290b4bf15184e42254bc/src/main/java/frc/robot/LogitechGamingPad.java#L231

https://github.com/OASTEM/Rapid-React-2022/blob/32054d1818b4a4878e84290b4bf15184e42254bc/src/main/java/frc/robot/LogitechGamingPad.java#L241

https://github.com/OASTEM/Rapid-React-2022/blob/32054d1818b4a4878e84290b4bf15184e42254bc/src/main/java/frc/robot/LogitechGamingPad.java#L251