search

Team612 / 612-2015

FRC team 612's repository for 2015 season
GNU General Public License v2.0
4 stars 6 forks source link

Dev autopickup #183

Closed WardBenjamin closed 9 years ago

CarlyAmar commented 9 years ago

Has some unnecessary changes, remove those and it is a good pull request

WardBenjamin commented 9 years ago

Fulfills https://github.com/Chantilly612Code/612-2015/issues/181 with no problems. If you have a problem with this, bring it up with Mr. Baer. There is no possible way that changes made here will break code and you don't want to admit that you are wrong. This is complete, and if you want more changes, then do them yourself. You said to complete a problem, and (finally) gave me some directions. This completes those directions, and does not introduce new problems.

CarlyAmar commented 9 years ago

If you can find time to perform a systems test with this code then I will merge.

WardBenjamin commented 9 years ago

This has been completed on the kitbot board @ZackAlfakir.

CarlyAmar commented 9 years ago

That is not a full systems check. Please reopen when systems check is performed on operational robot.

WardBenjamin commented 9 years ago

The kitbot is an operational robot, therefore it is a valid systems check.

portpiratech commented 9 years ago

Hi guys... i think we somehow got on your github email list by mistake. Can you check it out please.

Thanks, Jim V. Lead Mentor Port Piratech FRC Team 4804 On Mar 13, 2015 3:16 PM, "Benjamin Ward" notifications@github.com wrote:

The kitbot is an operational robot, therefore it is a valid systems check.

— Reply to this email directly or view it on GitHub https://github.com/Chantilly612Code/612-2015/pull/183#issuecomment-79336470 .

WardBenjamin commented 9 years ago

@portpiratech I believe it is because you are "watching" the repository. If you visit the github page there should be a button/dropdown menu on the top-right part of the page. Benjamin Ward, Programmer, FRC Team 612