search

Team612 / 612-2016

FRC Team 612's 2016 code for First Stronghold
GNU General Public License v2.0
9 stars 6 forks source link

Make shooter angle code actually use a controller #152

Closed Bobobalink closed 8 years ago

Bobobalink commented 8 years ago

Ben's jank-as-hell discreet proportional controller is dumb and wrong, we're going use a real PID controller.

WardBenjamin commented 8 years ago

...eventually.

ZachPerkins1 commented 8 years ago

..yes

Ahmad-Bamba commented 8 years ago

I'm reopening this because it's a good idea, but this isn't something that we should worry about until after competition. Don't make any super substantial code changes before Friday. It'll just create more unaccountable variables.

And as a side note, why is it that when we use Ben's stuff it's always really jank :P

ZachPerkins1 commented 8 years ago

I'm re-closing this because the shooter angle code already uses a PID controller.

ZachPerkins1 commented 8 years ago

Looking back, I suppose I should have specified that instead of just writing yes with two dots before it...

WardBenjamin commented 8 years ago

And as a side note, why is it that when we use Ben's stuff it's always really jank :p

Not always, just when I'm in a hurry and we need an implementation. Honestly, my stuff would require like zero tuning compared to this, so it would have been better to wait for this until after the first compo and focus on shooter testing. But whatever, it's done.