search

Team766 / MaroonFramework

Sketching ideas for an improved robot software framework
Other
2 stars 16 forks source link

Upstream changes from the 2022 repo #7

Closed rcahoon closed 2 years ago

rcahoon commented 2 years ago

This change is Reviewable

dejabot commented 2 years ago

Not at all - wasn't sure if I remembered hearing that was one of the changes under scrutiny (eg around the time we started seeing OOMEs) but sounds like not. Thx!

-------- Original Message -------- On May 4, 2022, 6:03 PM, Ryan Cahoon wrote:

@rcahoon commented on this pull request.

In src/main/java/com/team766/web/Dashboard.java:

@@ -0,0 +1,61 @@ +package com.team766.web;

not that I know of. I think the logger is where the memory leak was coming from, but I haven't had time to confirm that fully.

are you seeing something suspicious here?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because your review was requested.Message ID: @.***>