Fences don't connect AOF-1.14.4-4.0.1

[calloatti]

[calloatti]

[Shnupbups]

Does this only affect vanilla wooden fences? Does this affect vanilla Nether Brick fences? Does this affect Extra Pieces fences? What about fences from other mods?

[coderbot16]

This is likely a Fabriblocks issue, as it overrides the fences tag without including the vanilla entries as fallback. Since wooden_fences is simply referenced by fences, the resource loader bug causes only Fabriblocks fences and fences under minecraft: fences directly to work.

[calloatti]

Disabled Fabriblocks and the issue persists:

[coderbot16]

Try removing bambooeverything, it may override the tag as well.

[Shnupbups]

Why do i feel like it's gonna end up being my fault because i messed something up again?

[calloatti]

Edit: This test is flawed, new fences have to be placed to test

fabriblocks disabled bambooeverything disabled

---

fabriblocks disabled bambooeverything disabled extrapieces disabled (not your fault extra pieces!)

Any more ideas? What strings should I search for in the mod jars to find mods that may be messing this up?

[coderbot16]

If a mod jar contains a file under data/minecraft/tags/blocks/fences.json, it could cause the issue. You could try removing extra pieces but it probably doesn't cause the issue.

As always, the root issue is a bad jij of resource loader.

[Shnupbups]

Yeah, any mod that contains a data\minecraft\tags\blocks\fences.json is a potential culprit. Glad it's not EP though!

[coderbot16]

I'm not saying it's 100% not EP, just that it's unlikely... You never know what odd stuff can go on.

[Shnupbups]

I'm not saying it's 100% not EP, just that it's unlikely... You never know what odd stuff can go on.

Callo removed EP in the post above yours and confirmed it isn't the problem

[coderbot16]

ah nvm

[calloatti]

Well, all my testing was flawed, you have to place new fences to check if the problem was fixed.

Found this in fabriblocks fences.json

{
    "replace": false,
    "values": [
        "fabriblocks:red_nether_brick_fence"
    ]
}

And this in bambooeverything fences.json

{
  "replace": false,
  "values": [
    "bambooeverything:bamboo_fence"
  ]
}

Those are the only 2 mods in the pack that have a fences.json

Disabling both mods makes fences connect again

Enabling only bambooeverything breaks fences (fabriblocks disabled)

Enabling only fabriblocks breaks fences (bambooeverything disabled)

So bottom line, both mods have to be disabled to fix the problem

Image showing both working and broken fences, just to show you have to place new fences to test:

[calloatti]

Temporary fix in https://github.com/AllOfFabric/AOF/commit/5babdf4fa33328880b1508063a821815039dc4ad