TeamAOF / All-of-Fabric-7

Modpack containing the latest & best of Fabric on 1.20
41 stars 31 forks source link

Certain loot chests are rarely empty (happened in village here) #9

Closed SiriusBYT closed 6 months ago

SiriusBYT commented 1 year ago
[17:24:33] [Server thread/ERROR]: Unable to fill loot chest in ResourceKey[minecraft:dimension / minecraft:overworld] at class_2338{x=785, y=64, z=9018} as the loot table 'ctov:village/beach/farm' couldn't be resolved! Please search the loot table in `latest.log` to see if there are errors in loading.
[17:24:37] [Server thread/INFO]: Mean tick: 36ms increasing chunk view distance to: 32
[17:24:38] [Server thread/ERROR]: Unable to fill loot chest in ResourceKey[minecraft:dimension / minecraft:overworld] at class_2338{x=785, y=64, z=9017} as the loot table 'ctov:village/beach/farm' couldn't be resolved! Please search the loot table in `latest.log` to see if there are errors in loading.
[17:24:55] [Server thread/WARN]: Can't keep up! Is the server overloaded? Running 2149ms or 42 ticks behind
[17:25:39] [Server thread/INFO]: Mean tick: 31ms increasing simulation distance to: 12
[17:26:22] [Server thread/WARN]: Can't keep up! Is the server overloaded? Running 2021ms or 40 ticks behind
[17:26:22] [Server thread/INFO]: SiriusBYT has made the advancement [Distinct Shrubs]
[17:26:22] [Worker-Main-16/WARN]: Tried to access a block entity before it was created. class_2338{x=245, y=94, z=9078}
[17:26:22] [Worker-Main-16/WARN]: Tried to access a block entity before it was created. class_2338{x=245, y=94, z=9078}
[17:27:14] [Server thread/ERROR]: Unable to fill loot chest in ResourceKey[minecraft:dimension / minecraft:overworld] at class_2338{x=815, y=64, z=9001} as the loot table 'ctov:village/beach/farm' couldn't be resolved! Please search the loot table in `latest.log` to see if there are errors in loading.
[17:27:22] [Server thread/ERROR]: Unable to fill loot chest in ResourceKey[minecraft:dimension / minecraft:overworld] at class_2338{x=815, y=64, z=9002} as the loot table 'ctov:village/beach/farm' couldn't be resolved! Please search the loot table in `latest.log` to see if there are errors in loading.

image

There are no big errors in lastest.log which is weird

Linguardium commented 1 year ago

seems to be caused by the outdated ctov compatibility mods that were added in the openloader folders. i would report them to the ctov issue tracker

specifically make sure to mention that the issue occurs when the compatibility packs are added as datapacks (such as in this case its probably farmers delight)

https://github.com/ChoiceTheorem/ChoiceTheorem-s-overhauled-village/issues/new?assignees=ChoiceTheorem&labels=bug&projects=&template=bug_report.md&title=

hokomili commented 1 year ago

The loot table for this container [minecraft:chests/ancient_city] resolved to empty and loot could not be generated. Check your latest.log for errors. I'm now very disappointed.

KorcakDaniel commented 1 year ago

Any chest from Lootr mod in nether results to this:

[18:19:35] [Server thread/ERROR]: Unable to fill loot chest in ResourceKey[minecraft:dimension / minecraft:the_nether] at class_2338{x=-924, y=53, z=569} as the loot table 'minecraft:chests/nether_bridge' couldn't be resolved! Please search the loot table in `latest.log` to see if there are errors in loading.

When I searched for the loot table earlier in the logs, this came up:

[17:55:05] [Render thread/WARN]: Found loot table element validation problem in {loot_tables:dungeons_arise:chests/heavenly_challenger/heavenly_challenger_theater}.pools[5].entries[0]: Unknown loot table called minecraft:chests/nether_bridge
[17:55:05] [Render thread/WARN]: Found loot table element validation problem in {loot_tables:dungeons_arise:chests/bandit_towers/bandit_towers_rooms}.pools[3].entries[2]: Unknown loot table called minecraft:chests/desert_pyramid
[17:55:05] [Render thread/WARN]: Found loot table element validation problem in {loot_tables:dungeons_arise:chests/aviary/aviary_treasure}.pools[5].entries[0]: Unknown loot table called minecraft:chests/nether_bridge
[17:55:05] [Render thread/WARN]: Found loot table element validation problem in {loot_tables:dungeons_arise:chests/aviary/aviary_normal}.pools[5].entries[0]: Unknown loot table called minecraft:chests/nether_bridge
[17:55:05] [Render thread/WARN]: Found loot table element validation problem in {loot_tables:dungeons_arise:chests/shiraz_palace/shiraz_palace_gardens}.pools[3].entries[0]: Unknown loot table called minecraft:chests/desert_pyramid
[17:55:05] [Render thread/WARN]: Found loot table element validation problem in {loot_tables:dungeons_arise:chests/heavenly_conqueror/heavenly_conqueror_barrels}.pools[5].entries[0]: Unknown loot table called minecraft:chests/nether_bridge
[17:55:05] [Render thread/WARN]: Found loot table element validation problem in {loot_tables:dungeons_arise:chests/foundry/foundry_lava_pit}.pools[1].entries[0]: Unknown loot table called minecraft:chests/bastion_other
[17:55:05] [Render thread/WARN]: Found loot table element validation problem in {loot_tables:dungeons_arise:chests/foundry/foundry_passage_normal}.pools[1].entries[0]: Unknown loot table called minecraft:chests/bastion_hoglin_stable
[17:55:05] [Render thread/WARN]: Found loot table element validation problem in {loot_tables:bosses_of_mass_destruction:chests/obsidilith}.pools[1].entries[0]: Unknown loot table called minecraft:chests/end_city_treasure
[17:55:05] [Render thread/WARN]: Found loot table element validation problem in {loot_tables:dungeons_arise:chests/bandit_village/bandit_village_tents}.pools[3].entries[1]: Unknown loot table called minecraft:chests/desert_pyramid
[17:55:05] [Render thread/WARN]: Found loot table element validation problem in {loot_tables:dungeons_arise:chests/bandit_towers/bandit_towers_normal}.pools[3].entries[2]: Unknown loot table called minecraft:chests/desert_pyramid
[17:55:05] [Render thread/WARN]: Found loot table element validation problem in {loot_tables:dungeons_arise:chests/heavenly_challenger/heavenly_challenger_normal}.pools[5].entries[0]: Unknown loot table called minecraft:chests/nether_bridge
[17:55:05] [Render thread/WARN]: Found loot table element validation problem in {loot_tables:dungeons_arise:chests/bandit_towers/bandit_towers_barrels}.pools[3].entries[2]: Unknown loot table called minecraft:chests/desert_pyramid
[17:55:05] [Render thread/WARN]: Found loot table element validation problem in {loot_tables:dungeons_arise:chests/aviary/aviary_barrels}.pools[4].entries[0]: Unknown loot table called minecraft:chests/nether_bridge
[17:55:05] [Render thread/WARN]: Found loot table element validation problem in {loot_tables:dungeons_arise:chests/foundry/foundry_normal}.pools[1].entries[0]: Unknown loot table called minecraft:chests/bastion_other
[17:55:05] [Render thread/WARN]: Found loot table element validation problem in {loot_tables:dungeons_arise:chests/foundry/foundry_treasure}.pools[1].entries[0]: Unknown loot table called minecraft:chests/bastion_treasure
[17:55:05] [Render thread/WARN]: Found loot table element validation problem in {loot_tables:dungeons_arise:chests/heavenly_conqueror/heavenly_conqueror_normal}.pools[4].entries[0]: Unknown loot table called minecraft:chests/nether_bridge
[17:55:05] [Render thread/WARN]: Found loot table element validation problem in {loot_tables:dungeons_arise:chests/heavenly_challenger/heavenly_challenger_supply}.pools[3].entries[0]: Unknown loot table called minecraft:chests/nether_bridge
[17:55:05] [Render thread/WARN]: Found loot table element validation problem in {loot_tables:dungeons_arise:chests/heavenly_challenger/heavenly_challenger_treasure}.pools[5].entries[0]: Unknown loot table called minecraft:chests/nether_bridge
[17:55:05] [Render thread/WARN]: Found loot table element validation problem in {loot_tables:structory_towers:end_tower}.pools[0].entries[0]: Unknown loot table called minecraft:chests/end_city_treasure
[17:55:05] [Render thread/WARN]: Found loot table element validation problem in {loot_tables:dungeons_arise:chests/bandit_village/bandit_village_barrels}.pools[3].entries[1]: Unknown loot table called minecraft:chests/desert_pyramid
[17:55:05] [Render thread/WARN]: Found loot table element validation problem in {loot_tables:dungeons_arise:chests/plague_asylum/plague_asylum_potions}.pools[2].entries[0]: Unknown loot table called minecraft:chests/nether_bridge
[17:55:05] [Render thread/WARN]: Found loot table element validation problem in {loot_tables:dungeons_arise:chests/heavenly_rider/heavenly_rider_normal}.pools[3].entries[0]: Unknown loot table called minecraft:chests/nether_bridge
[17:55:05] [Render thread/WARN]: Found loot table element validation problem in {loot_tables:dungeons_arise:chests/heavenly_conqueror/heavenly_conqueror_treasure}.pools[6].entries[0]: Unknown loot table called minecraft:chests/nether_bridge
[17:55:05] [Render thread/WARN]: Found loot table element validation problem in {loot_tables:dungeons_arise:chests/ceryneian_hind/ceryneian__hind_treasure}.pools[3].entries[0]: Unknown loot table called minecraft:chests/desert_pyramid
[17:55:05] [Render thread/WARN]: Found loot table element validation problem in {loot_tables:dungeons_arise:chests/heavenly_rider/heavenly_rider_treasure}.pools[4].entries[0]: Unknown loot table called minecraft:chests/nether_bridge
[17:55:05] [Render thread/WARN]: Found loot table element validation problem in {loot_tables:dungeons_arise:chests/jungle_tree_house/jungle_tree_house_treasure}.pools[3].entries[0]: Unknown loot table called minecraft:chests/jungle_temple
[17:55:05] [Render thread/WARN]: Found loot table element validation problem in {loot_tables:dungeons_arise:chests/ceryneian_hind/ceryneian_hind_treasure}.pools[3].entries[0]: Unknown loot table called minecraft:chests/desert_pyramid
nitrofenix commented 1 year ago

Checked all other vanilla loot tables, only the list below were affected:

minecraft:chests/end_city_treasure
minecraft:chests/ancient_city
minecraft:chests/bastion_bridge
minecraft:chests/bastion_hoglin_stable
minecraft:chests/bastion_other
minecraft:chests/bastion_treasure
minecraft:chests/desert_pyramid
minecraft:chests/igloo_chest
minecraft:chests/jungle_temple

I believe the issue is caused by LootIntegrations, since the loot tables for those above all depend on mods that aren't present in AOF7, so they resolve to empty. An example, from dungeonloot_nether.json that modifies the minecraft:chests/nether_bridge loot table:

  "loot_table": "minecraft:chests/nether_bridge",
  "max_result_itemcount": 15,
  "integrated_loot_tables": {
    "dungeons_plus:chests/soul_prison/common": 6,
    "totw_additions:chests/nether_tower/nether_tower_chest": 6,
    "infernalexp:chests/desolate_bastion_outpost_chest": 9,
    "infernalexp:chests/glowstone_canyon_ruin_chest": 9,
    "infernalexp:chests/basalt_delta_ruin_chest": 9,
    "bygonenether:chests/citadel": 6,
    "bygonenether:chests/fortress": 6,
    "bygonenether:chests/catacomb/treasure_rib": 6,
    "awesomedungeonnether:chests/awesome_dungeon": 6,
    "philipsruins:chests/nether_ruins_low": 4,
    "infernalexp:chests/basalt_delta_ruin": 4,
    "infernalexp:chests/desolate_bastion_outpost": 6,
    "infernalexp:chests/glowstone_canyon_ruin": 4
  }
}

As a quick and dirty workaround in the interim, generated a datapack to reset the affected loot tables to Vanilla(-ish): lootfix_v0.3.zip

Have been using this for a little while in SP and it seems to fix the issue.

SubordinalBlue commented 1 year ago

Eyes open for next AoF7 release... CTOV has since updated to fix this (yes?)

nitrofenix commented 1 year ago

Yep, fixed in version 2.1a of the compat pack add-on.