search

TeamAOF / Craftoria

12 stars 20 forks source link

[Bug Report]: Client crash to desktop when typing in search field of creative menu (when mouse button 4 is bound to sneak) #191

Open reyals106 opened 1 month ago

reyals106 commented 1 month ago

Modpack Version

1.5.0

Describe your issue.

When the back mouse button (mouse button 4) is bound to sneak, searching in the creative menu will crash the game to desktop. When unbound and changed back to shift, no issues arise.

This was tested on multiple installs of the game.

Crash Report

https://gist.github.com/reyals106/c17b4f9959679c65b1bf3ce9a84cb2d0

Latest Log

No response

Have you modified the modpack?

No

User Modifications

No response

Did the issue happen in singleplayer or on a server?

Both

Discord Username

No response

ChocoMilc commented 1 month ago

This is happening to me in 1.4.1, and it seems to happen if you have anything bound to mouse button 4

SubordinalBlue commented 1 month ago

Hmm... does it happen for you with ultimate or open inventory bound to mouse button 4? Those two I often have bound to mouse buttons 4 or 5, and it's always worked fine.

(also, you'll probably want to update to latest pack version, 1.5.0... but that's a different matter)

SubordinalBlue commented 1 month ago

also, I see from the crash you are using JDK 21.0.3... 21.0.4 is latest, iirc. Normally shouldn't have to update, but maybe the included newer libglfw (or other supporting libs) will resolve the mouse button issue for you.

reyals106 commented 1 month ago

Updated to 21.0.5 using 1.5.0 and bound mouse 4 to open inventory to test and crash still occurred. Tested unbinding mouse button 4 and no crash.

Note that if you unbind mouse button 4 after already booting up minecraft, you'll have to restart again with the Mouse Button 4 unbound.

Incidentally it kept crashing with Mouse Button 4 unbound and sneak unassigned. I had to assign sneak left shift and creative mode worked fine and I was able to search.

If you change sneak to Mouse 4 after not experiencing a crash, you can search creative inventory no problem and use mouse button to sneak until you restart the game.

SubordinalBlue commented 1 month ago

I'll try and confirm on my machine, today or tomorrow, hopefully.

For a temporary solution... why use the creative inventory search at all? EMI's search seems more powerful. EMI has a "cheat mode" to use if one is in Creative mode (or has OP status on a server), where key-with-click will give you the items.

Linguardium commented 1 month ago

the posted error appears to be caused by Ars Nouveau referencing the render system when generating their tooltips https://github.com/baileyholl/Ars-Nouveau/blob/de1e870ba58bfe1905125e625f563d59d1c03f7c/src/main/java/com/hollingsworth/arsnouveau/common/items/PerkItem.java#L40

Someone should probably report it to them... (its probably due to them assuming the shift key is a keyboard input)