search

TeamAmalgam / kodkod

Kodkod relational model finder
Other
3 stars 0 forks source link

Refactors statistics and logging out of the algorithm subclasses #19

Closed AtulanZaman closed 11 years ago

AtulanZaman commented 11 years ago

Things to consider

-Refactored methods from having bounds passed in explicitly as arguements -Refactored out stats methods from being in the explicit solve methods to be methods in the super class. -Currently solveFirst and solveOne only has the stats method different between them. Should we merge these methods with the parent method?

Fixes #13

Reviewers: @cpkleynhans @joseph2625 @mhyee

mhyee commented 11 years ago

Looks good.

cpkleynhans commented 11 years ago

LGTM

mhyee commented 11 years ago

Looks good.

There was a question a while back about what the desc field does at https://github.com/TeamAmalgam/kodkod/commit/e439d41c806c18fb594d41cbb2602fed5aaab001#L2R35

It turns out this is actually needed by the Stats class.