TeamAmalgam / kodkod

Kodkod relational model finder
Other
3 stars 0 forks source link

Adding JUnit support. #2

Closed cpkleynhans closed 11 years ago

cpkleynhans commented 11 years ago

Changes:

Reviewers: @AtulanZaman @mhyee @joseph2625

mhyee commented 11 years ago

Two minor points: (currently) unnecessary import and trailing whitespace in various places.

We can ignore the minor points for now.

I also have two major comments:

cpkleynhans commented 11 years ago

I've fixed your minor points.

In order for us to download waf we would need to add another script or something to download dependencies. This seems a bit excessive so for waf we have two decisions really, include it in the repo, or assume the user has it installed already. I prefer including it in the repo.

Overflow appears to be using an older version of junit, so we would need to update the tests to the latest version. The tests are also organized in a slightly different way but it shouldn't be hard to adjust them.

mhyee commented 11 years ago

OK, looks good then.

joseph39 commented 11 years ago

looks good!

cpkleynhans commented 11 years ago

We discussed offline that we should move test building into its own task. I'll be pushing a commit with this change shortly.