search

TeamAmalgam / kodkod

Kodkod relational model finder
Other
3 stars 0 forks source link

Adding GIA #3

Closed mhyee closed 11 years ago

mhyee commented 11 years ago

This is basically a copy/paste of the existing multiobjective Kodkod parts into Kodkod 2.0. There were changes to the imports and build system to make it compile. These are also the minimum changes copied over to support solving multiobjective optimization problems.

We also removed a bunch of imports/dependencies to external libraries that we don't really need, such as sdg-util.

The motivation is so we can build Moolloy and set up unit tests and continuous integration.

Reviewers: @cpkleynhans @AtulanZaman @joseph2625

cpkleynhans commented 11 years ago

Is there any reason why we are placing GIA in kodkod.multiobjective.api instead of kodkod.multiobjective? Also we should change the names of the test namespaces to reflect the real namespaces.

cpkleynhans commented 11 years ago

We may want to add some basic tests before merging this into master. Maybe take one of the smaller rooks problems and convert it into a test?

mhyee commented 11 years ago

There is no particular reason for assigning the package names. My basic rule was to convert edu.mit.csail.sdg.moolloy.solver.kodkod to kodkod.multiobjective. A few files were moved around so we wouldn't have a single file in a package.

This is definitely open to discussion, but would probably fit better for when we actually refactor the code. Same goes for adding test cases and the method that was never called.

cpkleynhans commented 11 years ago

Ok, we can fix all of these issues during the refactor. LGTM

joseph39 commented 11 years ago

Looks good.