TeamAmaze / AmazeFileManager

Material design file manager for Android
https://teamamaze.xyz
GNU General Public License v3.0
5.1k stars 1.54k forks source link

Add FTP support #177

Closed AnderRasoVazquez closed 7 years ago

AnderRasoVazquez commented 8 years ago

I think it's a very useful function for a file manager.

Keep up the good work! =D

ghost commented 8 years ago

Support for SFTP would also be great

ghost commented 8 years ago

Yes, SFTP/SSH is something I'd like to see aswell. It should make you select/generate ssh keys and have a checkbox for use of a password instead of a key. This way it encourages people to use (far more secure) keys.

ghost commented 8 years ago

Is this being worked on? There is a great app on the play store called turbo ftp but I refuse to use it since it's not open-source and free as in free speech.

ghost commented 8 years ago

I'm having the feeling this project is abandoned..

ghost commented 8 years ago

And WebDAV?

ghost commented 8 years ago

We can use Sardine for WebDAV, JSch for SFTP and commons-net for FTP...

Zireael-N commented 8 years ago

I'm having the feeling this project is abandoned..

@JasperWeiss, well, this is a wrong feeling: commits @ master.

chenzhiwei commented 8 years ago

I think this feature can be delivered as a plugin. Just like Google Hangouts and Hangouts dialer.

ghost commented 8 years ago

If people need these features, please just use a stand alone app to accomplish this.

Have any of you ever found as nice a Light Weight & Simple File Manager as Amaze? I've not seen one, and I know for a fact Android needs this, not a bloated app.

Sorry I'm not trying to be rude, but I know what is needed, not another app with bloated features that the end-user can get already as a stand alone to accomplish what is needed.

Please let's keep this app as it is!

https://github.com/arpitkh96/AmazeFileManager/issues/245

----> KISS :)

alanjames1987 commented 8 years ago

@Geyup I think the decision to add FTP support should be up to the developers and creating a GitHub issue like this one is a great way to have a discussion around the merits of the feature.

I'm not trying to be rude, but I know what is needed,

You don't appear to be a developer of this project and thus should not think you know best. It's not an application that you control.

I personally like the idea of adding FTP support because I want a single application for managing my files, regardless of the way they are accessed, similar to what I have with Dolphin in Linux.

ghost commented 8 years ago

Yes you are correct, it's up to the developer. I'm only an end-user wishing to keep the file manager light, and not added features that are not needed.

If there was no such thing as an FTP application and someone then wanted such a feature added into a file manager, I could really see the need, but since there are many such apps, I just wanted to share my two cents that I think it's pointless...

xmikos commented 8 years ago

@Geyup I wholeheartedly disagree. For me as a Linux user, SFTP support is elemental and much needed feature (similar to SMB network shares for Windows users, which are already supported). Every Linux file manager supports it, even old console-based mc. In todays world, network file access is as much needed as local file access and I don't want different apps for it. File manager should support it by itself.

VishalNehra commented 8 years ago

I want to implement SFTP as I myself use Linux on my machine. But there's a big difference between wanting to, and actually implementing it. I will study about it as the time permits (:

ghost commented 8 years ago

IMHO implementing FTP is a disservice to the user in the end. Because it is so terribly insecure. It sends the username and password in plain text over the internet. Even with TLS I would not recommend it to anyone for any purpose (besides, perhaps, servers on a personal LAN)

SFTP would be great though, support for key files would be nice as well. To make things easier, you may want to look at the source code from ConnectBot.

xmikos commented 8 years ago

@JasperWeiss I agree, FTP should stay dead, it's horribly insecure zombie protocol :-) Only SFTP is relevant.

ghost commented 8 years ago

Yes it's up to the developer, BUT there are already FTP/SFTP applications for Android!

A File Manager is NOT a File Transfter Protocol Application!

I'm a Linux/Unix Geek, let's keep things where they belong, and using the right tool for the job!

KISS :)

ghost commented 8 years ago

@Geyup Actually, there isn't a good SFTP client yet. At least not open-source.

Second, a file manager app can be whatever you want it to be. The majority seems to want it to have built-in in SFTP support, including the developer.

Besides, I don't see your problem. If you want to use a separate app then go ahead. You'll barely notice it's there.

xmikos commented 8 years ago

@Geyup Amaze already supports SMB file transfer, adding SFTP therefore would not be against its concept. And I strongly disagree with you, file manager should also support managing files over network. Most Linux file managers supports it (e.g. mc, Dolphin, Krusader, Nautilus, etc.).

ghost commented 8 years ago

@xmikos

Dolphin, Krusader, Nautilus

Not one of those file managers is as small and light weight as Amaze is.

If Amaze wanted to become a bloated File manager, like the above mentioned named, I could see this happening.

Anyhow, enough on the subject... :)

Cheers

xmikos commented 8 years ago

@Geyup You have conveniently omitted mc, which definitely is lightweight file manager (at least in my definition of "lightweight") and supports many network file transfer protocols. You have also conveniently skipped part where I am pointing out that Amaze already supports SMB file transfer.

Your definition of bloated seems to be really strange and you seems to be overly obsessed with KISS (and this is coming from guy who uses Arch Linux and do most stuff in terminal). You can fork Amaze and strip all features if you want it that way, it's opensource, that's your call. But you shouldn't try to force your opinions on everyone else, most people here seems to disagree with you.

ghost commented 8 years ago

I'm not an Arch user, and sorry, I'm not trying to force my ideas on anyone.

Just simply saying, there are applications specifically designed to do the job is all, and no need to add in more features, when such applications exist.

Hope that's clear now.

ghost commented 8 years ago

@geyup Frankly, I haven't seen any well designed SFTP client on F-Droid.

We know very well what you're saying. We just don't necessarily agree with it.

ghost commented 8 years ago

@JasperWeiss don't get me wrong, if there's nothing good, then that's another story...

chenzhiwei commented 7 years ago

This feature was implemented in latest release, so I think it's time to close this thread.

JavaJens commented 7 years ago

@chenzhiwei @vishal0071 Can you tell me where this is implemented? I only see that support for serving files via FTP was added, but not accessing remote files. Or did I just miss understand the request?

chenzhiwei commented 7 years ago

@JavaJens Maybe I miss understand, I think this is request for an FTP server.

VishalNehra commented 7 years ago

@JavaJens ftp client will be implemented sooner than later since we've added server support now.

ghost commented 7 years ago

And SFTP?

jahirfiquitiva commented 7 years ago

Hi,

I'm not sure about how your implementation works, or its "purpose".

I really want the FTP and/or SFTP support, but the way Solid Explorer has it, which is being able to explorer files in another server, like for example the files of a website.

In Solid Explorer, you set the url, port, etc and it connects to those files.

I hope to see it in future updates.

VishalNehra commented 7 years ago

@wb9688 @ghost yes, SFTP is being worked upon, expect a release soon. However ftp client might take a bit more time. Stay tuned. @jahirfiquitiva as of now, you can't set port/path/username/password. But you gotta wait a bit, it is being worked upon.

cirelli94 commented 7 years ago

@vishal0071 Hi, updates about SFTP support?

flocke commented 7 years ago

If FTP support is being worked on you should probably re-open this issue so people can easily see that it's already planed. I was about to file a request for SFTP when I found this one ;)

VishalNehra commented 7 years ago

Consult #498 for Client support

ka223 commented 5 years ago

I can see SFTP at the cloud settings (beta version), can I connect to FTP as well?

jmshrv commented 5 years ago

Sorry to revive an old issue, but adding support for regular FTP would be great. Some devices (such as the Nintendo Switch) don't have SFTP/SCP/SMB clients and I have to use another app to get files from my Switch.