Reduce overdraw on About activity

[VishnuSanal]

activity_about.xml currently uses LinearLayouts, nested RelativeLayouts etc. I think we can reduce overdraws by using a ConstraintLayout. Moving "Translators" and "Contributors" to RecyclerViews would be helpful too.

[ArunPrasanth-V]

i would like to contribute! what i need to do now?

[VishnuSanal]

i would like to contribute!

Sure!

what i need to do now?

As said in the comment, the purpose of this issue is essentially to reduce overdraw on activity_about. Moving all the nested layouts to a ConstraintLayout would be a good start. Making "contributors" & "translators" sections dynamic would help too (@VishalNehra should these be individual issues?)

[VishnuSanal]

Making "contributors" & "translators" sections dynamic would help too (@VishalNehra should these be individual issues?)

@ArunPrasanth-V seems like you can decide this - can you work on both under this, provided this is a Issue-Easy (good first issue)? If not, feel free do the migration to ConstraintLayout only, we can make the other parts a new issue.

[ArunPrasanth-V]

since it is my first contribution. i need to move all the nested layout to a constraintLayout. if there any reference means that would be more helpfull either video or blog.

[VishnuSanal]

@ArunPrasanth-V Hi! Thanks for showing interest. I think docs would be a good place to started with ConstraintLayout. Also, feel free to join our telegram group if you've any queries :)

[ArunPrasanth-V]

@VishnuSanal i'm having doubt As you said moving all the nested layouts such as Relative layout. whether i need to replace all the RelativeLayout to ConstraintLayout in the code.

[VishnuSanal]

@ArunPrasanth-V Nope, I felt like everything can be done with a single ConstraintLayout as the root. If we replace every RelativeLayout with ConstraintLayout, we aren't reducing any overdraw.

[ArunPrasanth-V]

@VishnuSanal I need to change root layout (LinearLayout) to ConstraintLayout right! in the given code

1) In line number 63 only (or) i need change 76, authors (207)

2) translators ,contributors to RecyclerView.

if i'm worng correct me!

[VishnuSanal]

@ArunPrasanth-V

1. In line number 63 only

Need not replace the root LinearLayout (L#63), IMO - because it only contains elements that should be arranged linearly.

(or) i need change 76, authors (207), translators ,contributors to RecyclerView.

Yes, you'd need to replace every LinearLayouts inside those five CardViews to ConstraintLayouts

[VishnuSanal]

@ArunPrasanth-V Any updates here?

[ArunPrasanth-V]

@VishnuSanal I have changed LinearLayout to ConstraintLayout. Have a look at it!

[ArunPrasanth-V]

@VishnuSanal I couldn't figure out where the view was overdrawn.

[VishnuSanal]

@VishnuSanal I couldn't figure out where the view was overdrawn.

@ArunPrasanth-V I'll review your PR & give you my suggestions there, in a while. :)

[VishnuSanal]

@ArunPrasanth-V

@VishnuSanal I couldn't figure out where the view was overdrawn.

Okay, as pointed out early, changes on #3109 does not reduce any overdraw. The intention of this issue was to necessarily remove the nested layouts and replace them with a ConstraintLayout at the root.

Please refer to the tageed comment from this thread for reference. :)

1. In line number 63 only

Need not replace the root LinearLayout (L#63), IMO - because it only contains elements that should be arranged linearly.

(or) i need change 76, authors (207), translators ,contributors to RecyclerView.

Yes, you'd need to replace every LinearLayouts inside those five CardViews to ConstraintLayouts

[VishnuSanal]

@ArunPrasanth-V Are you still working on this?

[bimalkaf]

Hi @VishnuSanal , I am new to open source contribution, But i know development. Can i start working on this as this is good first issue?

[hammadrfq3]

Is it still open to work? Can i contribute to it?

[hammadrfq3]

Overdraw issue has been fixed in activity_about.xml. Should i open pull request now?