TeamAmaze / AmazeFileManager

Material design file manager for Android
https://teamamaze.xyz
GNU General Public License v3.0
5.31k stars 1.57k forks source link

SMB connection with space in username #403

Open MrReSc opened 7 years ago

MrReSc commented 7 years ago

Hi

I probably find an issue. If i try to connect to my smb shares, i always gets an error "unknown username or bad password". Our usernames has a space in between then name and surname. I already tried name\040surname, "name surname" and name%20surename. No of them was working. If i add a connection with a "no space" username, it works perfectly.

I'm using V3.1.1 from F-Droid

ANEast commented 7 years ago

I have also just noticed this. I think the bug lies in the connection class connectingWithSmbServer (line 297) in /src/main/java/com/amaze/filemanager/ui/dialogs/SmbConnectDialog.java

I am by no means an expert, but looking at the code, I think it is not possible for the user to escape characters as these are then URL encoded? I have tried all the options suggested by MrReSc, as well as enclosing them all in quotes. It always comes back with bad username or password. However, logging into a machine without a space in the username is fine.

I do note, however, that http://www.linuxquestions.org/questions/linux-networking-3/mount-t-smbfs-username-in-with-space-not-accepted-73557/ advises that spaces need the username to be quotation mark enclosed, and the space escaped.

I also note that the URLEncoder in Android https://developer.android.com/reference/java/net/URLEncoder.html encodes all spaces as "+" - surely this would also cause an incorrect password error - Firstname+Surname is definitely not the same password as Firstname Surname.

I hope that this can be fixed soon, as I used this feature a lot in ES Explorer, but have ditched ES due to the nag screens and other intrusive features. I do like Amaze, but need this function to work!

VishalNehra commented 7 years ago

Is the problem present on latest beta?

ANEast commented 7 years ago

Hi Vishal,

Thanks for looking at this. I have registered for the Beta program tonight, but I can't install it from the store. I have version 3.1.1 which was preinstalled on the system (Android Lollipop 5.1, Fairphone2). Google Play states 3.1.2 b7 also needs access to in-app purchases and identity. I then click okay and it comes up with an error "-505" and doesn't update.

If you can offer any suggestions (have tried clearing cache etc, but obviously can't remove APK as it is a system app).

Thanks.

VishalNehra commented 7 years ago

It was pre_installed? Well, you need to wait for the stable version then. Don't worry, I'll personally test for this issue and it's fix.

MrReSc commented 7 years ago

Thanks for your effort to fix this. Unfortunately it's not fixed on my side. I'm running v3.1.2 Beta 7 (on CM14.1) and still the same behaviour. Btw: I'm using a Synology NAS.

VishalNehra commented 7 years ago

Guys did you try with user\ name Meaning a \ preceding the space

MrReSc commented 7 years ago

It's not working either... :-( grafik

VishalNehra commented 7 years ago

Test on v3.1.2 beta 9

MrReSc commented 7 years ago

Thanks for your effort and for your work! Unhappily it's still not working on my end.

VishalNehra commented 7 years ago

I tried hard but couldn't find a solution. Anyone with knowledge about this issue, do guide what to do with usernames which has a space in between them on SMB servers.

MrReSc commented 7 years ago

Hi, any news about this problem?

VishalNehra commented 7 years ago

@MrReSc sasdly, no.. although I hope this will be fixed with the new implementation I'm currently working on which adds SMB v2/3 support.

EmmanuelMess commented 3 years ago

@TranceLove cant create username with space, can you test this?

TranceLove commented 3 years ago

@TranceLove cant create username with space, can you test this?

On Unix it is indeed impossible to create a SMB user with space in usernames; I think this implies SMB on Windows... will test.

jejo86 commented 1 year ago

You tagged this as Issue-WontFix. Could you please at least add a warning, shown when trying to enter a username with a space, so that it is clear, this does not work?

VishalNehra commented 1 year ago

You tagged this as Issue-WontFix. Could you please at least add a warning, shown when trying to enter a username with a space, so that it is clear, this does not work?

Makes sense