TeamAmaze / AmazeFileManager

Material design file manager for Android
https://teamamaze.xyz
GNU General Public License v3.0
5.08k stars 1.53k forks source link

Incorrect Copy Loop Detection Due to `String#contains` Logic #4131

Open im-samwong opened 1 month ago

im-samwong commented 1 month ago

Summary: The isCopyLoopPossible method incorrectly identifies a copy loop for similar but non-overlapping directory paths due to reliance on string contains logic. Located at app/src/test/java/com/amaze/filemanager/filesystem/OperationsTest.java

To Reproduce Steps to reproduce the behavior:

  1. Invoke the isCopyLoopPossible method programmatically within the app, passing a source file path and a target file path where the target path is similar but not actually a subdirectory of the source (e.g., /documents/work and /documents/workk).
  2. Observe the method's return value.

Expected behavior The method should return false, indicating no copy loop is possible because the target directory is not a subdirectory of the source directory.

Actual Outcome The method returns true, incorrectly suggesting a copy loop is possible due to the similarity of the paths.

Screenshots For this unit test:

  @Test
  public void testIsCopyLoopPossibleWithSimilarButNonOverlappingPaths() {
      HybridFileParcelable sourceFile = new HybridFileParcelable("/documents/work");
      HybridFile targetFile = new HybridFile(OpenMode.FILE, "/documents/workk");

      assertFalse("Copy loop should not be detected for similar but non-overlapping paths",
                Operations.isCopyLoopPossible(sourceFile, targetFile));
  }

bug

Smartphone (please complete the following information): N/A

Additional context There was no GUI error. Tried reproducing error on small scale on GUI with android emulator and no issues. Although, when trying to copy parent directory into subdirectory of itself, it copied over just empty directory. Could cause problems on a larger scale.