TeamAmaze / AmazeFileManager

Material design file manager for Android
https://teamamaze.xyz
GNU General Public License v3.0
5.24k stars 1.56k forks source link

Menu not aligned in Arab #4225

Open getgo-nobugs opened 1 month ago

getgo-nobugs commented 1 month ago

Describe the bug Menu text does not aligned consistently in arab

To Reproduce Steps to reproduce the behavior:

  1. Open the app
  2. Click "menu" button

Expected behavior Menu text does not aligned consistently in arab.

Screenshots

image

Smartphone (please complete the following information):

sanjai0py commented 1 month ago

I have identified the issue; it seems that there are some values that don't have proper translations. I believe that adding the correctly translated values will solve this. Please give a thumbs up if I am heading in the right direction!

image
VishnuSanal commented 1 month ago

@sanjai0py hi, thanks for your interest in contributing to amaze! the solution you suggested would work -- but it is practically almost impossible to achieve 100% translation coverage. to fix this issue, try settingsupportsRtl to true in the manifest.

sanjai0py commented 1 month ago

Hey @VishnuSanal, thanks for the reply. I understand that setting the android:supportsRtl="true" will only right-to-left align the contents, but it won't provide proper translation/internalization, right? I am new to Android.

image

VishnuSanal commented 1 month ago

@sanjai0py appreciate your enthusiasm in contributing to amaze!

I understand that setting the android:supportsRtl="true" will only right-to-left align the contents

yess - and, that's what this issue is about!

but it won't provide proper translation/internalization

we can't rely on having 100% translation for every language. itt is practically impossible to achieve that coverage. android falls back to the default strings in english in case of the non availability of translated strings.

this issue was that the text gets misaligned for those such strings. and, your new screenshot fixes this issue. please make a PR & we are good to go. :)

PS: if my assumptions are wrong, please correct me. ;)

hammadrfq3 commented 2 weeks ago

Hi VishnuSanal, Can i work on this issue? Also there were some strings not localized, now I have localized them

فيديوهات
<string name="analyse_storage">تحليل التخزين</string>
<string name="trash_bin">سلة المهملات</string>
VishnuSanal commented 2 weeks ago

hi @hammadrfq3, thanks for your interest in contributing to amaze! please wait for a few hours to confirm that @sanjai0py is no longer working on this issue. if not, you can proceed with this issue. :)

sanjai0py commented 2 weeks ago

Hey @VishnuSanal, I’m tied up with work and won’t be able to address this issue.