TeamAmaze / AmazeFileManager

Material design file manager for Android
https://teamamaze.xyz
GNU General Public License v3.0
5.25k stars 1.56k forks source link

[Regression] Picking a file with Amaze > v3.0.1 from another app returns no file (under AOSP 4.1.2) #640

Open Olf0 opened 7 years ago

Olf0 commented 7 years ago

When using Android's "share" functionality, Amaze versions higher than 3.0.1 crash. Tested with Amaze v3.0.1 (O.K.), v3.1.1 (crashes) and 3.1.2rc3 (crashes) under AOSP 4.1.2 on an Jolla 1 phone.

Please let me know, if it would be helpful for you to try to capture a log of these crashes or find tombstone files corresponding to these crashes, and transmit them to you.

Side note: Also tested these cases with a recent version of Ghost Commander (v1.53.10b4) and the last (good old) OI Filemanager (v2.0.5), and they both are working fine in all cases. Surprisingly though, Simple Explorer crashes in a very similar way, as Amaze > v3.0.1 does. All these file manages are Free Software and installed from F-Droid.

VishalNehra commented 7 years ago

I don't have that Android version anymore, so could you be kind enough to share logcat for each case? It would be great if you filter the log for Amaze only.

Olf0 commented 7 years ago

Oh, it is worse than I described: As I am using Amaze primarily as a provider for selecting files, I did not notice that Amaze 3.1.2rc3 already crashes when loosing focus (by user interaction) or even when trying to enter its settings.

As this prevents any proper testing (and maybe this already constitutes the real issue), I recorded logs filtered for the simple string "amaze" with CatLog and aLogcat-root for these simple cases (without any sharing involved, yet), see attached files:

If you need more information (e.g. logs recorded with different logging settings or tombstone files), please let me know.

P.S.: Not changing the subject of this issue yet, as I have the gut feeling, that not all reasons causing this are yet revealed.

Olf0 commented 7 years ago

With Amaze 3.1.2-RC4 the crashes are gone, both when using the "share" functionality and when entering its settings. :) Thanks! Testing the "sharing" and "open with" functions, specifically:

I will try to take a closer look at this last remaining issue the next weekend.

Olf0 commented 7 years ago

Logs:

HTH

P.S.: Calling Amaze 3.1.2rc4 from Conversations in order to pick a file exhibits the same behaviour: Everything seems to work, but no file is returned. With OI Filemanager 2.0.5 / 2.1.1 the same operation works fine.

VishalNehra commented 7 years ago

Should've been fixed with v3.2.0 Although picking up multiple files is still broken, let me know if you're still facing this issue.

Olf0 commented 7 years ago

Hmm, while looking every day for Amaze 3.2.0 to appear in the F-Droid client (and it is still not shown there), I took a closer look today and there seems to be some issue, if I am interpreting

We don't have the current version of this app. (Check mode: Tags) (Auto-update mode: None)

correctly.
Or is it just the F-Droidians lagging in building and publishing FOSS apps?

P.S.: I have never seen any Android file-manager app successfully picking multiple files for another app (at least in my environment, which is a bit special and outdated), but thus I only tried that a few times (then assuming this to generally not work). So while this does not seem to constitute a big disadvantage for Amaze in its current state (i.e. lacking the ability to pick multiple files in one go), having that working may make Amaze unique among them.

VishalNehra commented 7 years ago

Oh, Is it that rare? No wonder I couldn't make it work. As of now only picking a single file (or folder) is working. Ps. Fdroid takes time to build new versions that's why I have a separate distribution on AFH for fdroid-like builds.

Olf0 commented 7 years ago

Ah, "AFH" is "Android File Host" (took me some searching of the web), and there is Amaze@AFH. Will install and test this weekend, and provide feedback.

Olf0 commented 7 years ago

Unfortunately, picking a file still does not work for me. Tested with K9-Mail 5.208 and Amaze 3.2.0: Still everything seems to work, but ultimately no file (handle) is successfully returned. Checked with K9-Mail 5.208 and OI File Manager 2.1.1: Works. Cross-checked on another Jolla 1 phone (so also under AOSP 4.1.2) with K9-Mail 5.008 (!) and Amaze 3.0.1: Works.

@vishal0071, can you please reopen this bug.

I will record logs and upload them here, the next couple of days.

Olf0 commented 7 years ago

Logs for Amaze 3.2.1 (from f-droid):

Olf0 commented 7 years ago

(Positive) log for Amaze 3.0.1 (from f-droid):

VishalNehra commented 7 years ago

Hmm, the root problem was fixed as I stated earlier, this is just the API issue with Android. I'll quickly finalize a fix. Thanks for the logs (:

Olf0 commented 6 years ago

A release with these bug fix(es) or a beta version to test would be really nice, either on F-Droid or Amaze@AFH.

ildar commented 6 years ago

Kinda duplicate of https://github.com/arpitkh96/AmazeFileManager/issues/495

ildar commented 6 years ago

I mean, not a duplicate but related

Olf0 commented 6 years ago

Retested with Amaze 3.2.2 from F-Droid: Still no file handle returned when used as a file picker for K9-Mail, but now it makes K9 v5.403 crashing, when returning to it, in contrast to v3.1.2rc4 and v3.2.1 with K9 v5.208. All other aspects of the testing environment are the same as before.

Would it be helpful to provide fresh logs for this issue, now with Amaze 3.2.2 and K9-Mail 5.403? Were the logging settings / filters applied O.K., which I used for Amaze v3.1.2rc4 and v3.2.1?

P.S.: File picking with K9 5.403 still works fine, when using Amaze 3.0.1 or OI filemanager.

EmmanuelMess commented 6 years ago

Replicable in 3.3.0RC2 or RC3 (next week)?

Olf0 commented 5 years ago

Sorry, I lost track of this (and the very similar issues with Simple File Manager and Ghost Commander).

Retested with Amaze 3.3.0 from Google, as an release APK of v3.3.0 is missing at Github (in contrast to the v3.3.0 release candidates; you may want to upload the final v3.3.0 release APK, too) and at F-Droid (I know, that takes time). Behavior unchanged compared to v3.2.0 and 3.2.1: Everything seems to work, but no file handle is returned to the calling app (tried Conversations, K9-Mail and Firefox / Fennec).

Logs:

P.S.: Thus Amaze 3.0.1 is still the latest version working for me. Recent versions of Ghost Commander and OI File Manager (all versions) are also working fine.