search

TeamAmaze / AmazeFileManager

Material design file manager for Android
https://teamamaze.xyz
GNU General Public License v3.0
5.25k stars 1.56k forks source link

Use ACRA to send crash reports without user interaction #659

Open EmmanuelMess opened 7 years ago

EmmanuelMess commented 7 years ago

ACRA with Cloudant is a nice solution, and free.

VishalNehra commented 7 years ago

We don't have man power to manage that many crash reports. Plus, we can already get critical ones on Google Play Developer Console.

IzzySoft commented 2 years ago

@VishalNehra does it still hold true that ACRA is used opt-in? They changed the defaults a while ago, so I had to assign the Tracking anti-feature to the library. If you switched to the "prompt option" (i.e. the user is asked whether the report shall be sent), I can white-list it for Amaze. Otherwise I have to add the AF. Thanks in advance for letting me know!

IzzySoft commented 2 years ago

Looking at the code it seems the user is asked where to send the report to (email, Telegram, Clipboard, Github). If that's the only place handling reports, all should be fine and I can simply whitelist ACRA for Amaze. As I'm not an Android/Java dev I can however not be sure if I might not have missed something (especially as there are multiple public static void reportError() methods) – so I just hope for your confirmation :wink:

VishalNehra commented 2 years ago

Yes, that's the only place. User has to explicitly send us reports using either of these options and we have a backend which creates GitHub issues based on reports sent by user to either email or telegram. Thanks @IzzySoft for looking into it. I'll keep this issue open to remove our ACRA usage altogether.

VishnuSanal commented 2 years ago

@VishalNehra .

to remove our ACRA usage altogether.

Why?

IzzySoft commented 2 years ago

Thanks @VishalNehra – whitelisted ACRA then for Amaze. Opt-in is totally fine, and agree with @VishnuSanal that complete removal is not necessary: the users have the choice of where to report to, and even whether to report at all (they could simply close the dialog and nothing would be sent then), right? All fine then I'd say.

VishalNehra commented 2 years ago

I didn't mean to say I'll remove the reporting screen. Users will still be able to report via any of the platforms, it's just that we're not using any of the features of ACRA apart from providing a hook that initiates a activity in case of any crash. That can easily be implemented without the use of a library.

EmmanuelMess commented 2 years ago

What would this issue be now?