search

TeamAmeriFrance / Guide-API

An Open-Source API to make your own ingame guides.
MIT License
26 stars 20 forks source link

Should fix The-Fireplace/Mechanical-Soldiers#9 #87

Closed The-Fireplace closed 7 years ago

The-Fireplace commented 7 years ago

That crash should have been impossible, because an ItemStack's item should never be null, but for some reason, it looks like that's what it was. That is the only possible null in the line of code the crash report pointed to, the stack was null checked.

The-Fireplace commented 7 years ago

This closes #86 .

TehNut commented 7 years ago

I still feel like this is not needed. Since it's crashing on an oredict recipe, then somebody is probably adding an invalid stack to the oredict.

If you look through the client log, you can actually see JEI spamming errors around line 30847 about null items in stacks.

The-Fireplace commented 7 years ago

Ok, good point. Perhaps rather than crashing, Guide API should also spam errors when this happens, and handle the issue somehow. Even if it means skipping the page or something, it would still be better than crashing the game.