search

TeamAtomECS / AtomECS

Cold atom simulation code
GNU General Public License v3.0
46 stars 11 forks source link

There are some compiling error and more clippy warnings, I want to fix them #62

Closed necokeine closed 2 years ago

necokeine commented 2 years ago

Hi here,

I am new to here, and I want to fix compiling and clippy first, if there is any other issues, I may take one.

ElliotB256 commented 2 years ago

That would be very welcome, thank you for offering!

I could also add clippy to the CI to maintain going forward

necokeine commented 2 years ago

Thank you for your reply. I created a PR to fix compiling and some clippy. I can help you to add some git hooks to this repo, is it what you want?

ElliotB256 commented 2 years ago

If you have something already that would be very useful, I can add some information to the getting started guide/guide for contributors to also tell them how to run clippy.

ElliotB256 commented 2 years ago

PR merged!