search

TeamAtomECS / AtomECS

Cold atom simulation code
GNU General Public License v3.0
46 stars 11 forks source link

Fixing beam intensity gradient #83

Closed BrianBostwick closed 1 year ago

BrianBostwick commented 1 year ago

A factor of two missing from the intensity gradient vector caused incorrect dipole trap frequencies.

ElliotB256 commented 1 year ago

Hi Brian,

I'll merge this, thanks! Is there also a unit test that you could write to prevent an error like this from happening in the future?

For example, one such test would be a unit test that uses the intensity systems to calculate intensity at specific points, and the gradient systems to calculate the gradients, and then check that these systems all agree?