search

TeamAtomECS / AtomECS

Cold atom simulation code
GNU General Public License v3.0
46 stars 11 forks source link

Correcting speed of light definition #84

Closed BrianBostwick closed 1 year ago

ElliotB256 commented 1 year ago

Thanks for the PR! Good spot :)

Could you fix the unit test from the previous PR before I merge?

BrianBostwick commented 1 year ago

Yes, I am working on those now. There still seems to be some discrepancy between what I am calculating with Mathematica and what I am getting out of AtomECS. I will create a pull request with those once it is sorted out.

I figured this should be pulled faster, affecting more than just the gaussian beam code.

ElliotB256 commented 1 year ago

Sounds excellent, thanks very much!