TeamBasedInquiryLearning / checkit-tbil-la

https://teambasedinquirylearning.github.io/checkit-tbil-la/
MIT License
0 stars 1 forks source link

LE4 strange indexing bug #37

Open StevenClontz opened 3 years ago

StevenClontz commented 3 years ago

Having 0=0 as the first equation is non-ideal to begin with, but notice that also the x_4 terms appear as x_1 for some reason:

image

StevenClontz commented 3 years ago

(side note, the only time I saw this, the student simplified the equations and answered it correctly, so hurray)

siwelwerd commented 3 years ago

Also affects V9

Screenshot 2021-10-12 195012

siwelwerd commented 3 years ago

I am guessing it is a problem with latex_system_from_matrix() -- is that something we wrote? Google doesn't turn up anything for it.

https://github.com/TeamBasedInquiryLearning/checkit-tbil-la/blob/8dcd0442c3cbb21e628146957eb8e9585c461391/outcomes/V9.sage#L17

StevenClontz commented 3 years ago

we wrote it https://github.com/StevenClontz/checkit/blob/main/wrappers/sage_wrapper.sage#L53 I'll inspect this later

siwelwerd commented 3 years ago

So far, I have only seen this bug when there are 4 or 5 variables. Here's an example with 5 screenshot

StevenClontz commented 2 years ago

I believe this is fixed now (somehow) - I have a build in Canvas I made in September where the bug is gone, but the build I uploaded in August (and still have been using it seems) has the bug. I'll close this issue once we publish the fall improvements to the public bank.

siwelwerd commented 2 years ago

The build I made for this semester contains this bug.

StevenClontz commented 2 years ago

Having lived through it myself, my inclination is to ignore it and hope it comes out in the wash this summer of upgrading to CheckIt 0.2 and a reorganization of sections. But my arm can be twisted to track this down if it's causing you enough trouble.

siwelwerd commented 2 years ago

It's low priority, but I wanted to document that it still exists and needs fixing eventually.

Do we have any particular reason to believe this is going to fix itself? Are you planning to rewrite latex_system_from_matrix ?

StevenClontz commented 2 years ago

Thanks for pushing on this. I was mistaken, I'd forgotten that this function was added as a CheckIt feature. (In 0.2 this will be explicit as you'll need to call CheckIt.latex_system_from_matrix(): https://github.com/StevenClontz/checkit/blob/998ec54efd4f3af441fc689299609b45d0a5a63d/platform/src/checkit/wrapper/wrapper.sage#L3 https://github.com/StevenClontz/checkit/blob/998ec54efd4f3af441fc689299609b45d0a5a63d/platform/src/checkit/wrapper/wrapper.sage#L62 )

I can't sniff out the cause of this bug for the life of me (LE4 just passes a matrix), but I'll open https://github.com/StevenClontz/checkit/issues/62 to make sure it's looked at.

siwelwerd commented 2 years ago

I had some time this morning to try and track this down, but now I can't replicate. It definitely exists in the build I created on 1/7, but it does not appear to exist in the build Dave created on 2/1 🤷‍♂️

StevenClontz commented 2 years ago

It's my hope that it's an issue caused by me hacking the version of CheckIt running in the TBIL CoCalc, but I have no idea when/how that could have happened.