Closed siwelwerd closed 1 month ago
I'm not sure that the first one is best by completing the square since it factors so easily. I get that we are trying to pigeonhole them and they use factoring on another. But it feels insincere to say that's the "best" way.
(Maybe this is better in the discussion than the pull request!)
(Maybe this is better in the discussion than the pull request!)
Since this hasn't been merged yet, we can keep changing it here. But after something is merged, then yes, discuss additional changes in a relevant issue (but crosslinking to related things like a recently merged PR is also helpful).
I'm not sure that the first one is best by completing the square since it factors so easily.
Anything with rational roots is going to factor, so I made them irrational in the latest commit.
The example looks good, but I don't know enough about the code and what you changed to know if it works in general! We'll say yes for now.
I also requested a review from @StevenClontz to eyeball the code for any glaring boneheaded mistakes.
Merge or dismiss my suggestion, then this should be ready to squash and merge I think.
Addresses #300
Fixes errors in answers and tweaks square root property task to include irrational roots.