search

TeamBasedInquiryLearning / precalculus

ARCHIVED - Materials for running a Team-Based Inquiry Learning precalculus course (in active development!)
https://teambasedinquirylearning.github.io/precalculus/
Other
4 stars 0 forks source link

Broken images #230

Closed siwelwerd closed 5 months ago

siwelwerd commented 5 months ago

Having trouble tracking this down. I think this was introduced when I merged #228 yesterday. In the build of instructor-web, I see this

warning: Unable to generate some sageplot images:
warning:  'NoneType' object has no attribute 'split'

And then PreTeXt happily reports it was successful, and many images are broken throughout the book. I don't see this error in the previous PR I merged (#227)--I think it was introduced by Tonya's commit. Frustratingly, running pretext build web and pretext generate on my machine seem to work fine, so I am not able to isolate this any further.

StevenClontz commented 5 months ago

I don't think the NoneType thing is related to image generation. Can you link me to a broken image - at a glance I didn't see one.

StevenClontz commented 5 months ago

The NoneType issue is related to pretext support command, probably a regression in the latest pretext version.

siwelwerd commented 5 months ago

I noticed them in Activity 3.1.10, but spot checking anything from the later modules they seem to be missing.

I think the 'NoneType' is a python thing trying to split an empty string.

StevenClontz commented 5 months ago

I think the 'NoneType' is a python thing trying to split an empty string.

Yup I'm tackling that now. It's related to the sage executable, which seems related.

StevenClontz commented 5 months ago

For whatever reason, the Codespace doesn't have Sage installed.

StevenClontz commented 5 months ago

This is upstream, tracking at https://github.com/PreTeXtBook/pretext-cli/pull/729

siwelwerd commented 5 months ago

For whatever reason, the Codespace doesn't have Sage installed.

Oh, is that why @AbbyANoble was having trouble with the image this morning?

siwelwerd commented 5 months ago

Ah, I see this commit showed up between our last working build and the first broken one... Starting to suspect Tonya is off the hook 🤣

siwelwerd commented 5 months ago

Just confirmed that the latest deployment has images. Thanks to @oscarlevin for the upstream fix that took care of this.