search

TeamBasedInquiryLearning / precalculus

ARCHIVED - Materials for running a Team-Based Inquiry Learning precalculus course (in active development!)
https://teambasedinquirylearning.github.io/precalculus/
Other
4 stars 0 forks source link

Remove commentary stringparam #269

Closed siwelwerd closed 3 months ago

siwelwerd commented 3 months ago

Each build is throwing a PTX:DEPRECATE error about the old commentary string parameter:

    * PTX:DEPRECATE: (2024-02-16) the  commentary  string parameter has been deprecated, is no longer functional, and has no replacement.  Instead control the visibility of a "commentary" element by placing it into a component and using version support.  You likely also have related deprecation messages about that situation which are more informative.
    * --------------

I think since we are on 2.4.1 now, we are safe to just remove it, as we already set up the instructor component.

Should probably be a good citizen and submit an update to the documentation, which still advises the use of this.

StevenClontz commented 3 months ago

PR to docs: https://github.com/PreTeXtBook/pretext/pull/2166 (thanks for the nudge Drew)

siwelwerd commented 3 months ago

Thanks, I went to try and do that myself but gave up when I couldn't figure out where the source for the guide actually lived. I even looked in the guide to see if it would tell me where to propose enhancements to the guide, but I didn't see that anywhere in there... (maybe I should make a PR to add that now that I see where to do that).