search

TeamCHK / yubaba

Chrome extension that generates article summaries using NLP
2 stars 0 forks source link

Message Passing and API Call #13

Closed junhur closed 2 years ago

junhur commented 2 years ago

Closes #8

chorongi commented 2 years ago

  1. Is background.ts currently designed to support both page content summary & pop up style summary?

  2. app.py line 23) was wondering if there was a specific reason behind setting input text as text=(content.text + ' ' + content.text) instead of text = context.text

junhur commented 2 years ago
  1. Is background.ts currently designed to support both page content summary & pop up style summary?

A: Not entirely sure what you mean by page content summary. But right now, background.ts grabs text from contentScript.ts where article text would be. Then passes it to dummy MLIS and forwards the response to popup.ts

  1. app.py line 23) was wondering if there was a specific reason behind setting input text as text=(content.text + ' ' + content.text) instead of text = context.text

A: app.py currently just serves as a dummy placeholder service for MLIS. returning content.text twice to provide an obvious distinction between what is coming from content script vs what is coming from service.

@chorongi let me know if you need more clarification