search

TeamCOMPAS / COMPAS

COMPAS rapid binary population synthesis code
http://compas.science
MIT License
65 stars 66 forks source link

Supernova being recorded twice in SSE_Supernovae output #1074

Closed SimonStevenson closed 7 months ago

SimonStevenson commented 8 months ago

Describe the bug I am trying to look at a population of supernovae using COMPAS. I noticed that I was getting more supernovae than the number of (single) stars that I evolved, which seemed weird. Turns out each supernova appears twice in my output (example below).

Label the issue urgency_moderate - This is a moderately urgent issue severity_moderate - This is a moderately severe bug

To Reproduce MWE: ./COMPAS --mode SSE --metallicity 0.0142 --maximum-evolution-time 500 --initial-mass-min 10.0 --remnant-mass-prescription FRYER2012 --kick-magnitude-distribution MAXWELLIAN --number-of-systems 100 --logfile-type CSV --quiet

This runs a small population of single stars. Inspect COMPAS_Output_X/SSE_Supernovae.csv and see that each supernova is listed twice (same seed, same time) with some differences in other parameters.

Expected behavior Each supernova record occurs only once.

Versioning (please complete the following information):

jeffriley commented 8 months ago

l'll take a look at this one - I think I might have introduced this when I did the BSE vs SSE changes.

ilyamandel commented 7 months ago

Could this be related to #1084 (i.e., could we be logging a clone)?

jeffriley commented 7 months ago

No, this was an unintended consequence of the BSE vs SSE changes. See PR #1092