TeamCOMPAS / COMPAS

COMPAS rapid binary population synthesis code
http://compas.science
MIT License
64 stars 64 forks source link

Change to CHeB end-of-phase core mass calculation #1107

Closed jeffriley closed 2 months ago

jeffriley commented 2 months ago

@ilyamandel this PR changes the way core mass is calculated at CHeB end of phase. COMPAS now calculates core mass at phase end the same way the Hurley sse code does, but Hurley et al. 2000 eqs 66 & 67 seem to suggest it shouldn't make a difference - if Mc increases linearly on phase until it gets to Mc,BAGB at phase end, then eqs 66 & 67 should yield the save value at phase end - maybe the devil is in the detail somewhere (maybe the "is approximated" just before eq 66 is germane). Either way, this fix solves the problem of the 50 Msol star having that odd spike in Teff at the end of the CheB phase/start of the HeMS phase.

github-actions[bot] commented 2 months ago

badge

Build Successful! You can find a link to the downloadable artifact below.

Name Link
Commit 1dd0223b4aedc66ce0fe78617d7c4098fece4fb2
Logs https://github.com/TeamCOMPAS/COMPAS/actions/runs/8935772539
Download https://github.com/TeamCOMPAS/COMPAS/suites/$SUITE_ID/artifacts/$ARTIFACT_ID