search

TeamCOMPAS / COMPAS

COMPAS rapid binary population synthesis code
http://compas.science
MIT License
64 stars 66 forks source link

Move compiler standard from c++11 to c++17 #1116

Closed jeffriley closed 4 months ago

jeffriley commented 4 months ago
  1. changed compiler standard from c++11 to c++17 in Makefile - see issue #984 (Tested ok with Ubuntu v20.04, g++ v11.04, and boost v1.74; and macOS v14.1.1, clang v15.0.0, and boost v1.85.)
  2. added check for boost version to allow for deprecated filesystem option
  3. added requirements.in file to online docs to specify requirements for latest

@ilyamandel:

  1. is straightforward
  2. is the #defines in Log.h and changed code in Log.cpp. We currently use boost::copy_file, but since c++17 the std::filesystem::copy_file is available. For now, untyil eveyone moves to c++17, I'm leaving boost::copy_file in Log.cpp - but after some (maybe extended) grace period I'll plan to replace it with std::filesystem::copy_file
  3. The online docs haven't been building for the past three months... The problem is that the theme we use isn't compatible with sphinx 7 and above. I'm hoping the 'requirements.in' file will fix it - if not, I'll try again...