search

TeamCOMPAS / COMPAS

COMPAS rapid binary population synthesis code
http://compas.science
MIT License
64 stars 64 forks source link

Renamed variable in dynamical tides to avoid confusion #1146

Closed veome22 closed 3 weeks ago

veome22 commented 3 weeks ago

A small variable name change, as requested by @ilyamandel .

Please let me know if I should also add this to the changelog.

veome22 commented 3 weeks ago

@jeffriley I agree, it only shows up once. I had defined one_minus_beta along with the other variables before I realized this. I can remove the definition.

And just to clarify-- does this change need a note in the changelog?

jeffriley commented 3 weeks ago

And just to clarify-- does this change need a note in the changelog?

Yes, we should. I know it feels like it's not necessary in this case, but if we don't, then two users might have different code, but both labelled with the same version - that's not right... Just note it as "code cleanup".

ilyamandel commented 3 weeks ago

Thank you, @veome22 , looks good! I agree with Jeff's suggestion of removing the extra variable you don't really need and updating the changelog. @jeffriley , I'll be traveling back to Australia over the next couple of days, so I hope you can approve.