TeamCOMPAS / COMPAS

COMPAS rapid binary population synthesis code
http://compas.science
MIT License
64 stars 66 forks source link

Remove `example_bbh_compas_config` and use just the `compasConfigDefault.yaml+CLI` args in the CI #1152

Closed avivajpeyi closed 3 weeks ago

avivajpeyi commented 3 months ago

People will forget to update both compasConfigDefault.yaml and example_bbh_compas_config. Lets update the CI to use compasConfigDefault.yaml (default settings) but only over-write the initial conditions as command-line arguments.

Details

From convo between Ilya+Avi: ``` Avi: > ... I noticed some other errors in the CI logs: https://github.com/TeamCOMPAS/COMPAS/actions/runs/9589100365/job/26442327180#step:8:27 Run example COMPAS job using the config example_bbh_compas_config.yaml Commandline Options error: option '--mass-transfer-jloss-macleod-linear-fraction' is ambiguous and matches '--mass-transfer-jloss-macleod-linear-fraction-degen', and '--mass-transfer-jloss-macleod-linear-fraction-non-degen' Use option '-h' (or '--help') to see (descriptions of) available options python_version = 3 compas_executable_override /home/runner/work/COMPAS/COMPAS/src/COMPAS grid_filename Grid_demo.txt /home/runner/work/COMPAS/COMPAS/src/COMPAS --debug-to-file False --detailed-output --enable-warnings False --errors-to-file False --evolve-unbound-systems False --population-data-printing False --print-bool-as-string False --quiet False --rlof-printing --store-input-files --switch-log False --check-photon-tiring-limit False --use-mass-loss --allow-touching-at-birth False --angular-momentum-conservation-during-circularisation False --allow-rlof-at-birth --circularise-binary-during-mass-transfer --hmxr-binaries False --mass-transfer --retain-core-mass-during-caseA-mass-transfer False --common-envelope-allow-immediate-RLOF-post-CE-survive False --common-envelope-allow-main-sequence-survive --common-envelope-allow-radiative-envelope-survive False --common-envelope-lambda-nanjing-enhanced False --common-envelope-lambda-nanjing-interpolate-in-mass False --common-envelope-lambda-nanjing-interpolate-in-metallicity False --common-envelope-lambda-nanjing-use-rejuvenated-mass False --revised-energy-formalism-nandez-ivanova False --allow-non-stripped-ECSN --pair-instability-supernovae --pulsational-pair-instability --evolve-pulsars False --debug-level 0 --logfile-common-envelopes-record-types -1 --logfile-detailed-output-record-types -1 --logfile-double-compact-objects-record-types -1 --logfile-pulsar-evolution-record-types -1 --logfile-rlof-parameters-record-types -1 --logfile-supernovae-record-types -1 --logfile-system-parameters-record-types -1 --grid-start-line 0 --hdf5-chunk-size 100000 --hdf5-buffer-size 1 --log-level 0 --maximum-evolution-time 13700.0 --maximum-number-timestep-iterations 99999 --number-of-systems 10 --timestep-multiplier 1 --cool-wind-mass-loss-multiplier 1.0 --initial-mass-min 5.0 --initial-mass-max 150.0 --initial-mass-power 0.0 --metallicity 0.0142 --metallicity-min 0.000.... Ilya: On the --mass-transfer-jloss-macleod-linear-fraction option: the option is correctly split into --mass-transfer-jloss-macleod-linear-fraction-degen and --mass-transfer-jloss-macleod-linear-fraction-non-degen in ../compas_python_utils/preprocessing/compasConfigDefault.yaml , so are we using some other yaml file for these testing runs? Avi: From the above logs it looks like we are using: `example_bbh_compas_config.yaml`, not the default compasConfigDefault.yaml This is because we check that the output from example_bbh_compas_config produces a BBH, and we use this output in other testing (testing of the python utilities). So maybe I just need to add in these new arguments to the example_bbh_compas_config Ilya: People will forget to update both compasConfigDefault.yaml and example_bbh_compas_config. I would suggest changing the process a bit to use compasConfigDefault.yaml (default settings) but only over-write the initial conditions as command-line arguments. ```

ilyamandel commented 3 weeks ago

Closing, fixed by @avivajpeyi in #1195 .