search

TeamCOMPAS / COMPAS

COMPAS rapid binary population synthesis code
http://compas.science
MIT License
64 stars 66 forks source link

Evolve after 2nd supernova #167

Closed SimonStevenson closed 4 years ago

SimonStevenson commented 4 years ago

We should make sure that all commits here http://gitlab.sr.bham.ac.uk/COMPAS/COMPAS/commits/evolve_after_2nd_SN after 10th Dec 2018 are ported over to new COMPAS. This includes some tweaks to timestepping for pulsar evolution (should check pulsar properties don't change more than few percent per timestep), and allowing the binary to contiue evolving after DCO formation.

SimonStevenson commented 4 years ago

At least in spirit, if not the actual code :)

ilyamandel commented 4 years ago

Any updates, @debatric ?

debatric commented 4 years ago

I have updated everything except allowing evolution after DCO formation. Should I do the old way of introducing a new switch to turn on or off by the user if they wish to continue evolution after DCO forms ? We used 'evolve_after_2nd_SN' tag in the python submit file for legacy. Right now, this may be only needed for pulsar-related projects.

ilyamandel commented 4 years ago

Why not just continue the evolution past DCO formation whenever --evolve-pulsars is on, @debatric ?

SimonStevenson commented 4 years ago

Sounds sensible :)

ilyamandel commented 4 years ago

@SimonStevenson -- so, if either binary in a DCO is an NS, and --evolve-pulsars is on, we should just continue the evolution until we hit one of the other termination conditions (time steps or total time), correct?

SimonStevenson commented 4 years ago

Yes (or until the binary merges due to gravitational wave emission)

ilyamandel commented 4 years ago

But that's not something we actually do at the moment (change the orbit in response to GW emission). Though I agree that we should. :)

SimonStevenson commented 4 years ago

Right, in Debatri's code we just used the merger time (which we do calculate) as a stopping condition.

ilyamandel commented 4 years ago

OK, doing that in the next commit.

ilyamandel commented 4 years ago

Implemented in #407, closing.