Describe the bug
When either star of a binary undergoes RLOF at birth and the allow-rlof-at-birth program option is true we equilibrate the masses of the stars and and circularise the binary, then we recalculate other attributes of the stars (radius, luminosity etc.)based on the new masses. When the initial parameters of the binaries are supplied by the user via a grid file we do not reset the ZAMS values for the attributes of the stars to the newly calculated values - we should.
Label the issue
urgency_low - This issue is not urgent
severity_minor - This is a minor bug with minimal impact
To Reproduce
Steps to reproduce the behavior:
Use a grid file with the following values:
Mass_1,Mass_2,Metallicity_1,Metallicity_2,Separation,Eccentricity
5.01898,0.131986,7.94E-04,7.94E-04,0.01198,0.0
and run COMPAS. The detailed output file will show that the masses were equilibrated and the binary circularised, but that the ZAMS values were not reset.
Expected behavior
When using a grid file, ZAMS values reset when equilibrating masses and circularising a binary at birth
Screenshots
n/a
Versioning (please complete the following information):
jeffriley
commented
4 years ago
Describe the bug When either star of a binary undergoes RLOF at birth and the allow-rlof-at-birth program option is true we equilibrate the masses of the stars and and circularise the binary, then we recalculate other attributes of the stars (radius, luminosity etc.)based on the new masses. When the initial parameters of the binaries are supplied by the user via a grid file we do not reset the ZAMS values for the attributes of the stars to the newly calculated values - we should.
Label the issue urgency_low - This issue is not urgent severity_minor - This is a minor bug with minimal impact
To Reproduce Steps to reproduce the behavior:
Use a grid file with the following values: Mass_1,Mass_2,Metallicity_1,Metallicity_2,Separation,Eccentricity 5.01898,0.131986,7.94E-04,7.94E-04,0.01198,0.0
and run COMPAS. The detailed output file will show that the masses were equilibrated and the binary circularised, but that the ZAMS values were not reset.
Expected behavior When using a grid file, ZAMS values reset when equilibrating masses and circularising a binary at birth
Screenshots n/a
Versioning (please complete the following information):
Additional context n/a